From: Anton Nefedov <anton.nefedov@virtuozzo.com>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "qemu-block@nongnu.org" <qemu-block@nongnu.org>,
"kwolf@redhat.com" <kwolf@redhat.com>,
"mreitz@redhat.com" <mreitz@redhat.com>,
"eblake@redhat.com" <eblake@redhat.com>,
Denis Lunev <den@virtuozzo.com>,
"berto@igalia.com" <berto@igalia.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
Anton Nefedov <anton.nefedov@virtuozzo.com>
Subject: [Qemu-devel] [PATCH v11 06/10] file-posix: reset fallocate-related flags without CONFIG_FALLOCATE*
Date: Tue, 18 Dec 2018 07:57:40 +0000 [thread overview]
Message-ID: <20181218075707.12006-7-anton.nefedov@virtuozzo.com> (raw)
In-Reply-To: <20181218075707.12006-1-anton.nefedov@virtuozzo.com>
these flags currently affect nothing without CONFIG_FALLOCATE*, so it's
not a bug. Fixing it makes possible to adjust supported zero flag
BDRV_REQ_ALLOCATE regardless of configuration (in the following patch).
Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
---
block/file-posix.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/block/file-posix.c b/block/file-posix.c
index d8f0b93752..a65e464cbc 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -1488,9 +1488,7 @@ static ssize_t handle_aiocb_write_zeroes_block(RawPosixAIOData *aiocb)
static int handle_aiocb_write_zeroes(void *opaque)
{
RawPosixAIOData *aiocb = opaque;
-#if defined(CONFIG_FALLOCATE) || defined(CONFIG_XFS)
BDRVRawState *s = aiocb->bs->opaque;
-#endif
#ifdef CONFIG_FALLOCATE
int64_t len;
#endif
@@ -1514,6 +1512,8 @@ static int handle_aiocb_write_zeroes(void *opaque)
}
s->has_write_zeroes = false;
}
+#else
+ s->has_write_zeroes = false;
#endif
#ifdef CONFIG_FALLOCATE_PUNCH_HOLE
@@ -1533,6 +1533,8 @@ static int handle_aiocb_write_zeroes(void *opaque)
s->has_discard = false;
}
}
+#else
+ s->has_discard = false;
#endif
#ifdef CONFIG_FALLOCATE
@@ -1546,6 +1548,8 @@ static int handle_aiocb_write_zeroes(void *opaque)
}
s->has_fallocate = false;
}
+#else
+ s->has_fallocate = false;
#endif
return -ENOTSUP;
--
2.17.1
next prev parent reply other threads:[~2018-12-18 7:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 7:57 [Qemu-devel] [PATCH v11 00/10] qcow2: cluster space preallocation Anton Nefedov
2018-12-18 7:57 ` [Qemu-devel] [PATCH v11 01/10] mirror: inherit supported write/zero flags Anton Nefedov
2018-12-18 7:57 ` [Qemu-devel] [PATCH v11 02/10] blkverify: set " Anton Nefedov
2018-12-18 7:57 ` [Qemu-devel] [PATCH v11 03/10] quorum: set supported write flags Anton Nefedov
2018-12-18 7:57 ` [Qemu-devel] [PATCH v11 04/10] block: introduce BDRV_REQ_ALLOCATE flag Anton Nefedov
2018-12-20 15:09 ` Vladimir Sementsov-Ogievskiy
2019-01-07 14:22 ` Alberto Garcia
2018-12-18 7:57 ` [Qemu-devel] [PATCH v11 05/10] block: treat BDRV_REQ_ALLOCATE as serialising Anton Nefedov
2019-01-07 15:19 ` Alberto Garcia
2018-12-18 7:57 ` Anton Nefedov [this message]
2018-12-21 13:51 ` [Qemu-devel] [PATCH v11 06/10] file-posix: reset fallocate-related flags without CONFIG_FALLOCATE* Vladimir Sementsov-Ogievskiy
2019-01-07 15:22 ` Alberto Garcia
2018-12-18 7:57 ` [Qemu-devel] [PATCH v11 07/10] file-posix: support BDRV_REQ_ALLOCATE Anton Nefedov
2018-12-21 14:18 ` Vladimir Sementsov-Ogievskiy
2019-01-07 15:24 ` Alberto Garcia
2018-12-18 7:57 ` [Qemu-devel] [PATCH v11 08/10] block: support BDRV_REQ_ALLOCATE in passthrough drivers Anton Nefedov
2018-12-18 7:57 ` [Qemu-devel] [PATCH v11 09/10] qcow2: skip writing zero buffers to empty COW areas Anton Nefedov
2018-12-21 16:16 ` Vladimir Sementsov-Ogievskiy
2018-12-24 8:21 ` Anton Nefedov
2018-12-24 8:33 ` Vladimir Sementsov-Ogievskiy
2019-01-08 13:40 ` Alberto Garcia
2018-12-18 7:57 ` [Qemu-devel] [PATCH v11 10/10] iotest 134: test cluster-misaligned encrypted write Anton Nefedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218075707.12006-7-anton.nefedov@virtuozzo.com \
--to=anton.nefedov@virtuozzo.com \
--cc=berto@igalia.com \
--cc=den@virtuozzo.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).