From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53266) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZGlq-0006Mk-8Q for qemu-devel@nongnu.org; Tue, 18 Dec 2018 09:54:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZGlp-0001mE-5M for qemu-devel@nongnu.org; Tue, 18 Dec 2018 09:54:54 -0500 Date: Tue, 18 Dec 2018 09:54:34 -0500 From: "Michael S. Tsirkin" Message-ID: <20181218095334-mutt-send-email-mst@kernel.org> References: <20181218110333.22558-1-philmd@redhat.com> <20181218092648-mutt-send-email-mst@kernel.org> <028f1498-d0bc-e920-1c7c-9a1f0bdded58@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <028f1498-d0bc-e920-1c7c-9a1f0bdded58@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 0/3] Fix strncpy() warnings for GCC8 new -Wstringop-truncation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , qemu-devel@nongnu.org, Ben Pye , Stefan Weil , Howard Spoelstra , Jeff Cody , =?iso-8859-1?Q?C=E9dric?= Le Goater , Thomas Huth , Liu Yuan , Igor Mammedov , Max Reitz , Kevin Wolf , Eric Blake , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , David Hildenbrand , David Gibson , Markus Armbruster , qemu-block@nongnu.org, "Dr. David Alan Gilbert" , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , 1803872@bugs.launchpad.net, Juan Quintela On Tue, Dec 18, 2018 at 03:45:08PM +0100, Paolo Bonzini wrote: > On 18/12/18 15:31, Michael S. Tsirkin wrote: > > Do you happen to know why does it build fine with > > Gcc 8.2.1? > > > > Reading the GCC manual it seems that > > there is a "nostring" attribute that means > > "might not be 0 terminated". > > I think we should switch to that which fixes the warning > > but also warns if someone tries to misuse these > > as C-strings. > > > > Seems to be a better option, does it not? > > > > > > Using strpadcpy is clever and self-documenting, though. We have it > already, so why not use it. > > Paolo The advantage of nonstring is that it will catch attempts to use these fields with functions that expect a 0 terminated string. strpadcpy will instead just silence the warning. -- MST