qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PULL 7/7] qapi: fix flat union on uncovered branches conditionals
Date: Tue, 18 Dec 2018 11:09:41 +0100	[thread overview]
Message-ID: <20181218100941.25267-8-armbru@redhat.com> (raw)
In-Reply-To: <20181218100941.25267-1-armbru@redhat.com>

From: Marc-André Lureau <marcandre.lureau@redhat.com>

Default branches variant should use the member conditional.

This fixes compilation with --disable-replication.

Fixes: 335d10cd8e2c3bb6067804b095aaf6371fc1983e

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20181217204046.14861-1-marcandre.lureau@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Long line wrapped]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 scripts/qapi/common.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py
index 8c2d97369e..c89edc0cb0 100644
--- a/scripts/qapi/common.py
+++ b/scripts/qapi/common.py
@@ -1460,7 +1460,8 @@ class QAPISchemaObjectTypeVariants(object):
             cases = set([v.name for v in self.variants])
             for m in self.tag_member.type.members:
                 if m.name not in cases:
-                    v = QAPISchemaObjectTypeVariant(m.name, 'q_empty')
+                    v = QAPISchemaObjectTypeVariant(m.name, 'q_empty',
+                                                    m.ifcond)
                     v.set_owner(self.tag_member.owner)
                     self.variants.append(v)
         for v in self.variants:
-- 
2.17.2

  parent reply	other threads:[~2018-12-18 10:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-18 10:09 [Qemu-devel] [PULL 0/7] QAPI patches for 2018-12-18 Markus Armbruster
2018-12-18 10:09 ` [Qemu-devel] [PULL 1/7] qapi: Turn ShutdownCause into QAPI enum Markus Armbruster
2018-12-18 10:09 ` [Qemu-devel] [PULL 2/7] qmp: Add reason to SHUTDOWN and RESET events Markus Armbruster
2018-12-18 10:09 ` [Qemu-devel] [PULL 3/7] qmp: Split ShutdownCause host-qmp into quit and system-reset Markus Armbruster
2018-12-18 10:09 ` [Qemu-devel] [PULL 4/7] qmp: query-current-machine with wakeup-suspend-support Markus Armbruster
2018-12-18 10:09 ` [Qemu-devel] [PULL 5/7] qga: update guest-suspend-ram and guest-suspend-hybrid descriptions Markus Armbruster
2018-12-18 10:09 ` [Qemu-devel] [PULL 6/7] qmp hmp: Make system_wakeup check wake-up support and run state Markus Armbruster
2018-12-18 10:09 ` Markus Armbruster [this message]
2018-12-19 15:30 ` [Qemu-devel] [PULL 0/7] QAPI patches for 2018-12-18 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181218100941.25267-8-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).