From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Ben Pye" <ben@curlybracket.co.uk>,
"Stefan Weil" <sw@weilnetz.de>,
"Howard Spoelstra" <hsp.cat7@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jeff Cody" <jcody@redhat.com>, "Cédric Le Goater" <clg@kaod.org>,
"Thomas Huth" <thuth@redhat.com>,
"Liu Yuan" <namei.unix@gmail.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Max Reitz" <mreitz@redhat.com>, "Kevin Wolf" <kwolf@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Markus Armbruster" <armbru@redhat.com>,
qemu-block@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
1803872@bugs.launchpad.net, "Juan Quintela" <quintela@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH v2 0/3] Fix strncpy() warnings for GCC8 new -Wstringop-truncation
Date: Tue, 18 Dec 2018 12:03:30 +0100 [thread overview]
Message-ID: <20181218110333.22558-1-philmd@redhat.com> (raw)
GCC 8 new warning prevents builds to success since quite some time.
First report on the mailing list is in July 2018:
https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03723.html
Various intents has been sent to fix this:
- Incorrectly using g_strlcpy()
https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg03705.html
https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg03706.html
- Using assert() and strpadcpy()
https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg03938.html
- Use #pragma GCC diagnostic ignored "-Wstringop-truncation"
https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04261.html
- adding an inline wrapper with said pragma in there
https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04261.html
- -Wno-stringop-truncation is the makefile
https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04261.html
This series replace the strncpy() calls by strpadcpy() which seemed
to me the saniest option.
Regards,
Phil.
Marc-André Lureau (1):
hw/acpi: Replace strncpy() by strpadcpy(pad='\0')
Philippe Mathieu-Daudé (2):
block/sheepdog: Replace strncpy() by strpadcpy(pad='\0')
migration: Replace strncpy() by strpadcpy(pad='\0')
block/sheepdog.c | 6 +++---
hw/acpi/aml-build.c | 6 ++++--
hw/acpi/core.c | 13 +++++++------
migration/global_state.c | 4 ++--
4 files changed, 16 insertions(+), 13 deletions(-)
--
2.17.2
next reply other threads:[~2018-12-18 11:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 11:03 Philippe Mathieu-Daudé [this message]
2018-12-18 11:03 ` [Qemu-devel] [PATCH v2 1/3] hw/acpi: Replace strncpy() by strpadcpy(pad='\0') Philippe Mathieu-Daudé
2018-12-18 11:09 ` Philippe Mathieu-Daudé
2018-12-18 14:29 ` Igor Mammedov
2018-12-18 11:03 ` [Qemu-devel] [PATCH v2 2/3] block/sheepdog: " Philippe Mathieu-Daudé
2018-12-18 11:03 ` [Qemu-devel] [PATCH v2 3/3] migration: " Philippe Mathieu-Daudé
2018-12-18 14:31 ` [Qemu-devel] [PATCH v2 0/3] Fix strncpy() warnings for GCC8 new -Wstringop-truncation Michael S. Tsirkin
2018-12-18 14:36 ` Daniel P. Berrangé
2018-12-18 14:39 ` Michael S. Tsirkin
2018-12-18 14:45 ` Paolo Bonzini
2018-12-18 14:54 ` Michael S. Tsirkin
2018-12-18 16:38 ` Paolo Bonzini
2018-12-18 17:03 ` Michael S. Tsirkin
2018-12-18 17:38 ` Daniel P. Berrangé
2018-12-18 16:55 ` Philippe Mathieu-Daudé
2018-12-18 17:04 ` Michael S. Tsirkin
2018-12-18 17:12 ` Paolo Bonzini
2018-12-18 17:17 ` Michael S. Tsirkin
2018-12-18 17:38 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218110333.22558-1-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=1803872@bugs.launchpad.net \
--cc=armbru@redhat.com \
--cc=ben@curlybracket.co.uk \
--cc=berrange@redhat.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=hsp.cat7@gmail.com \
--cc=imammedo@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=namei.unix@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=sw@weilnetz.de \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).