From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZDEl-0001Ac-G0 for qemu-devel@nongnu.org; Tue, 18 Dec 2018 06:08:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZDAe-0008O2-Ri for qemu-devel@nongnu.org; Tue, 18 Dec 2018 06:04:17 -0500 From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Date: Tue, 18 Dec 2018 12:03:30 +0100 Message-Id: <20181218110333.22558-1-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v2 0/3] Fix strncpy() warnings for GCC8 new -Wstringop-truncation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Ben Pye , Stefan Weil , Howard Spoelstra , "Michael S. Tsirkin" , Jeff Cody , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Thomas Huth , Liu Yuan , Igor Mammedov , Max Reitz , Kevin Wolf , Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , David Hildenbrand , David Gibson , Markus Armbruster , qemu-block@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Dr. David Alan Gilbert" , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , 1803872@bugs.launchpad.net, Juan Quintela , Paolo Bonzini GCC 8 new warning prevents builds to success since quite some time. First report on the mailing list is in July 2018: https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03723.html Various intents has been sent to fix this: - Incorrectly using g_strlcpy() https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg03705.html https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg03706.html - Using assert() and strpadcpy() https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg03938.html - Use #pragma GCC diagnostic ignored "-Wstringop-truncation" https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04261.html - adding an inline wrapper with said pragma in there https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04261.html - -Wno-stringop-truncation is the makefile https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04261.html This series replace the strncpy() calls by strpadcpy() which seemed to me the saniest option. Regards, Phil. Marc-Andr=C3=A9 Lureau (1): hw/acpi: Replace strncpy() by strpadcpy(pad=3D'\0') Philippe Mathieu-Daud=C3=A9 (2): block/sheepdog: Replace strncpy() by strpadcpy(pad=3D'\0') migration: Replace strncpy() by strpadcpy(pad=3D'\0') block/sheepdog.c | 6 +++--- hw/acpi/aml-build.c | 6 ++++-- hw/acpi/core.c | 13 +++++++------ migration/global_state.c | 4 ++-- 4 files changed, 16 insertions(+), 13 deletions(-) --=20 2.17.2