From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Halil Pasic" <pasic@linux.ibm.com>,
"Laurent Vivier" <laurent@vivier.eu>,
qemu-block@nongnu.org, "Cornelia Huck" <cohuck@redhat.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Michael Tokarev" <mjt@tls.msk.ru>,
"Richard Henderson" <rth@twiddle.net>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Michael Roth" <mdroth@linux.vnet.ibm.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-s390x@nongnu.org, "Collin Walling" <walling@linux.ibm.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>, "Max Reitz" <mreitz@redhat.com>,
qemu-trivial@nongnu.org
Subject: [Qemu-devel] [PULL 3/4] vl: Use error_fatal to simplify obvious fatal errors (again)
Date: Tue, 18 Dec 2018 15:28:50 +0100 [thread overview]
Message-ID: <20181218142851.9477-4-laurent@vivier.eu> (raw)
In-Reply-To: <20181218142851.9477-1-laurent@vivier.eu>
From: Markus Armbruster <armbru@redhat.com>
Patch created mechanically by rerunning:
$ spatch --in-place --sp-file scripts/coccinelle/use-error_fatal.cocci \
--macro-file scripts/cocci-macro-file.h vl.c
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20181213175807.12039-1-armbru@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
vl.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/vl.c b/vl.c
index 2a8b2ee16d..530fad6a71 100644
--- a/vl.c
+++ b/vl.c
@@ -3133,11 +3133,8 @@ int main(int argc, char **argv, char **envp)
Visitor *v;
BlockdevOptions_queue *bdo;
- v = qobject_input_visitor_new_str(optarg, "driver", &err);
- if (!v) {
- error_report_err(err);
- exit(1);
- }
+ v = qobject_input_visitor_new_str(optarg, "driver",
+ &error_fatal);
bdo = g_new(BlockdevOptions_queue, 1);
visit_type_BlockdevOptions(v, NULL, &bdo->bdo,
--
2.19.2
next prev parent reply other threads:[~2018-12-18 14:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 14:28 [Qemu-devel] [PULL 0/4] Trivial patches patches Laurent Vivier
2018-12-18 14:28 ` [Qemu-devel] [PULL 1/4] docs/devel/build-system: fix 'softmu' typo Laurent Vivier
2018-12-18 14:28 ` [Qemu-devel] [PULL 2/4] i386: hvf: drop debug printf in decode_sldtgroup Laurent Vivier
2018-12-18 14:28 ` Laurent Vivier [this message]
2018-12-18 14:28 ` [Qemu-devel] [PULL 4/4] error: Remove NULL checks on error_propagate() calls Laurent Vivier
2018-12-19 18:49 ` [Qemu-devel] [PULL 0/4] Trivial patches patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218142851.9477-4-laurent@vivier.eu \
--to=laurent@vivier.eu \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mjt@tls.msk.ru \
--cc=mreitz@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).