From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: vsementsov@virtuozzo.com
Subject: [Qemu-devel] [PATCH v2 0/3] nbd-client: drop extra error noise
Date: Tue, 18 Dec 2018 16:57:11 -0600 [thread overview]
Message-ID: <20181218225714.284495-1-eblake@redhat.com> (raw)
This is a counter-proposal to Vladimir's initial post for
reducing the noise in iotest 083. The difference is that
I dropped error_get_hint, since I couldn't find any useful
hint to be traced during transmission phase in the first place,
and instead added a trace message for the one place where we
do set hints during handshaking phase.
Eric Blake (1):
nbd/client: Trace all server option error messages
Vladimir Sementsov-Ogievskiy (2):
nbd: publish _lookup functions
block/nbd-client: use traces instead of noisy error_report_err
include/block/nbd.h | 5 +++++
nbd/nbd-internal.h | 5 -----
block/nbd-client.c | 23 +++++++++++++++++++----
nbd/client.c | 2 ++
block/trace-events | 4 ++++
nbd/trace-events | 1 +
tests/qemu-iotests/083.out | 28 ----------------------------
7 files changed, 31 insertions(+), 37 deletions(-)
--
2.17.2
next reply other threads:[~2018-12-18 22:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 22:57 Eric Blake [this message]
2018-12-18 22:57 ` [Qemu-devel] [PATCH v2 1/3] nbd: publish _lookup functions Eric Blake
2018-12-18 22:57 ` [Qemu-devel] [PATCH v2 2/3] nbd/client: Trace all server option error messages Eric Blake
2018-12-19 11:41 ` Vladimir Sementsov-Ogievskiy
2018-12-18 22:57 ` [Qemu-devel] [PATCH v2 3/3] block/nbd-client: use traces instead of noisy error_report_err Eric Blake
2018-12-19 12:03 ` [Qemu-devel] [PATCH v2 0/3] nbd-client: drop extra error noise Vladimir Sementsov-Ogievskiy
2018-12-19 17:22 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218225714.284495-1-eblake@redhat.com \
--to=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).