From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZXZ6-0008PY-6T for qemu-devel@nongnu.org; Wed, 19 Dec 2018 03:50:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZXZ3-00049j-1R for qemu-devel@nongnu.org; Wed, 19 Dec 2018 03:50:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34654) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gZXZ2-00049G-QT for qemu-devel@nongnu.org; Wed, 19 Dec 2018 03:50:48 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 98EDB792B8 for ; Wed, 19 Dec 2018 08:50:47 +0000 (UTC) From: Peter Xu Date: Wed, 19 Dec 2018 16:50:34 +0800 Message-Id: <20181219085038.7729-1-peterx@redhat.com> Subject: [Qemu-devel] [PATCH 0/4] q35: change defaults for kernel irqchip and IR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "Michael S . Tsirkin" , Eduardo Habkost , Igor Mammedov , peterx@redhat.com, Paolo Bonzini This only changes q35. Nothing else. Before this series, we have these default parameters: - machine kernel-irqchip: on - intel-iommu IR: off This series wants to change these default variables into: - machine kernel-irqchip: split - intel-iommu IR: on and at the meantime we should keep compatibility with old kernels and old versions of QEMU. For old versions of QEMU: we used machine compat properties. For old kernels (<4.4): if user didn't specify split kernel irqchip, we'll take it only as the first priority if it's supported by the kernel; otherwise, we will continue with complete kernel irqchip. Both of these parameters should be good to have (split irqchip gains more security, while IR gets it too but even more, like x2apic). So let's try to make them as default if capable. Tests ("split" stands for whether kernel split irqchip enabled, "IR" stands for whether IR is turned on): |--------------------------------------------------------+-------+----| | params | split | IR | |--------------------------------------------------------+-------+----| | -M q35 | 0 | / | | -M q35,accel=kvm | 1 | / | | -M pc-q35-3.1,accel=kvm | 0 | / | | -M q35,accel=kvm,kernel-irqchip=off | 0 | / | | -M q35,accel=kvm,kernel-irqchip=on | 0 | / | | -M q35 -device intel-iommu | 0 | 1 | | -M q35,accel=kvm -device intel-iommu | 1 | 1 | | -M q35,accel=kvm,kernel-irqchip=on -device intel-iommu | 0 | 0 | |--------------------------------------------------------+-------+----| I didn't try old kernels, though. Any comment would be welcomed, thanks. Peter Xu (4): kvm: let split be optional for kvm_arch_irqchip_create q35: set split kernel irqchip as default x86-iommu: switch intr_supported to OnOffAuto type x86-iommu: turn on IR by default if proper accel/kvm/kvm-all.c | 3 ++- hw/core/machine.c | 2 ++ hw/i386/acpi-build.c | 6 +++--- hw/i386/amd_iommu.c | 2 +- hw/i386/intel_iommu.c | 6 +++--- hw/i386/pc.c | 2 +- hw/i386/pc_q35.c | 2 ++ hw/i386/x86-iommu.c | 18 +++++++++++++++--- include/hw/boards.h | 1 + include/hw/i386/x86-iommu.h | 4 +++- target/i386/kvm.c | 6 +++--- 11 files changed, 36 insertions(+), 16 deletions(-) -- 2.17.1