From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZddB-0005gT-VZ for qemu-devel@nongnu.org; Wed, 19 Dec 2018 10:19:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZddA-0003tp-JM for qemu-devel@nongnu.org; Wed, 19 Dec 2018 10:19:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58406) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gZddA-0003sp-Ax for qemu-devel@nongnu.org; Wed, 19 Dec 2018 10:19:28 -0500 From: Paolo Bonzini Date: Wed, 19 Dec 2018 16:18:45 +0100 Message-Id: <20181219151917.3874-4-pbonzini@redhat.com> In-Reply-To: <20181219151917.3874-1-pbonzini@redhat.com> References: <20181219151917.3874-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 03/35] checkpatch: fix premature exit when no input or --mailback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= In some cases, checkpatch's process subroutine is exiting the whole process. This is wrong, just return from the subroutine instead. Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Paolo Bonzini --- scripts/checkpatch.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 18e16b79df..66eb68e85a 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2867,19 +2867,19 @@ sub process { # If we have no input at all, then there is nothing to report on # so just keep quiet. if ($#rawlines =3D=3D -1) { - exit(0); + return 1; } =20 # In mailback mode only produce a report in the negative, for # things that appear to be patches. if ($mailback && ($clean =3D=3D 1 || !$is_patch)) { - exit(0); + return 1; } =20 # This is not a patch, and we are are in 'no-patch' mode so # just keep quiet. if (!$chk_patch && !$is_patch) { - exit(0); + return 1; } =20 if (!$is_patch) { --=20 2.20.1