From: Peter Xu <peterx@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, "Michael S . Tsirkin" <mst@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/3] q35: change defaults for kernel irqchip and IR
Date: Thu, 20 Dec 2018 18:16:58 +0800 [thread overview]
Message-ID: <20181220101658.GA24875@xz-x1> (raw)
In-Reply-To: <be579ef2-4722-f986-cc2f-1acab8a92335@redhat.com>
On Thu, Dec 20, 2018 at 11:00:21AM +0100, Paolo Bonzini wrote:
> On 20/12/18 06:40, Peter Xu wrote:
> > For old versions of QEMU: we used machine compat properties.
> >
> > For old kernels (<4.4): if user didn't specify split kernel irqchip,
> > we'll take it only as the first priority if it's supported by the
> > kernel; otherwise, we will continue with complete kernel irqchip.
> >
> > Both of these parameters should be good to have (split irqchip gains
> > more security, while IR gets it too but even more, like x2apic). So
> > let's try to make them as default if capable.
>
> This is not correct anymore, but the commit message in patch 1 is
> correct, so
Indeed; I should remove the old cover letter to avoid confusion.
>
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Thanks!
--
Peter Xu
prev parent reply other threads:[~2018-12-20 10:17 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 5:40 [Qemu-devel] [PATCH v2 0/3] q35: change defaults for kernel irqchip and IR Peter Xu
2018-12-20 5:40 ` [Qemu-devel] [PATCH v2 1/3] q35: set split kernel irqchip as default Peter Xu
2018-12-20 12:13 ` Eduardo Habkost
2019-04-26 19:27 ` Alex Williamson
2019-04-26 19:27 ` Alex Williamson
2019-04-26 21:02 ` Alex Williamson
2019-04-26 21:02 ` Alex Williamson
2019-04-27 5:29 ` Paolo Bonzini
2019-04-27 5:29 ` Paolo Bonzini
2019-04-27 8:09 ` Paolo Bonzini
2019-04-27 8:09 ` Paolo Bonzini
2019-04-29 14:21 ` Alex Williamson
2019-04-29 14:21 ` Alex Williamson
2019-04-29 14:55 ` Eduardo Habkost
2019-04-29 14:55 ` Eduardo Habkost
2019-04-29 15:22 ` Alex Williamson
2019-04-29 15:22 ` Alex Williamson
2019-05-03 18:42 ` Eduardo Habkost
2019-05-03 18:42 ` Eduardo Habkost
2019-05-05 9:06 ` Peter Xu
2019-05-05 9:06 ` Peter Xu
2019-05-06 16:13 ` Paolo Bonzini
2019-05-06 21:16 ` Eduardo Habkost
2019-05-03 20:00 ` Michael S. Tsirkin
2019-05-03 20:00 ` Michael S. Tsirkin
2019-05-03 20:23 ` Eduardo Habkost
2019-05-03 20:23 ` Eduardo Habkost
2019-05-06 16:17 ` Paolo Bonzini
2019-04-30 23:01 ` Alex Williamson
2019-04-30 23:01 ` Alex Williamson
2019-04-30 23:09 ` Paolo Bonzini
2019-04-30 23:09 ` Paolo Bonzini
2019-05-01 0:28 ` Alex Williamson
2019-05-01 0:28 ` Alex Williamson
2018-12-20 5:40 ` [Qemu-devel] [PATCH v2 2/3] x86-iommu: switch intr_supported to OnOffAuto type Peter Xu
2018-12-20 5:40 ` [Qemu-devel] [PATCH v2 3/3] x86-iommu: turn on IR by default if proper Peter Xu
2018-12-20 10:00 ` [Qemu-devel] [PATCH v2 0/3] q35: change defaults for kernel irqchip and IR Paolo Bonzini
2018-12-20 10:16 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220101658.GA24875@xz-x1 \
--to=peterx@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).