From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gaKL0-0005pU-On for qemu-devel@nongnu.org; Fri, 21 Dec 2018 07:55:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gaKKx-0006S6-I9 for qemu-devel@nongnu.org; Fri, 21 Dec 2018 07:55:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46474) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gaKKx-0006Qo-BT for qemu-devel@nongnu.org; Fri, 21 Dec 2018 07:55:31 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E124FC7E9D for ; Fri, 21 Dec 2018 12:55:28 +0000 (UTC) Date: Fri, 21 Dec 2018 13:55:23 +0100 From: Cornelia Huck Message-ID: <20181221135523.0a4353a0.cohuck@redhat.com> In-Reply-To: <20181221090410.27250-11-marcandre.lureau@redhat.com> References: <20181221090410.27250-1-marcandre.lureau@redhat.com> <20181221090410.27250-11-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v7 10/28] compat: replace PC_COMPAT_2_10 & HW_COMPAT_2_10 macros List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau Cc: qemu-devel@nongnu.org, imammedo@redhat.com, ehabkost@redhat.com On Fri, 21 Dec 2018 13:03:52 +0400 Marc-Andr=C3=A9 Lureau wrote: > Use static arrays instead. >=20 > Suggested-by: Eduardo Habkost > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > include/hw/boards.h | 3 +++ > include/hw/compat.h | 11 ----------- > include/hw/i386/pc.h | 17 ++--------------- > hw/arm/virt.c | 6 +----- > hw/core/machine.c | 13 +++++++++++++ > hw/i386/pc.c | 17 +++++++++++++++++ > hw/i386/pc_piix.c | 7 ++----- > hw/i386/pc_q35.c | 7 ++----- > hw/ppc/spapr.c | 6 +----- > hw/s390x/s390-virtio-ccw.c | 6 +----- > 10 files changed, 42 insertions(+), 51 deletions(-) Reviewed-by: Cornelia Huck