From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gaKWV-0002yf-Ig for qemu-devel@nongnu.org; Fri, 21 Dec 2018 08:07:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gaKWU-0007Xb-8y for qemu-devel@nongnu.org; Fri, 21 Dec 2018 08:07:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59450) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gaKWS-0007Vd-Bs for qemu-devel@nongnu.org; Fri, 21 Dec 2018 08:07:25 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2C46E13AA0 for ; Fri, 21 Dec 2018 13:07:23 +0000 (UTC) Date: Fri, 21 Dec 2018 14:07:17 +0100 From: Cornelia Huck Message-ID: <20181221140717.6e2c0ecc.cohuck@redhat.com> In-Reply-To: <20181221090410.27250-18-marcandre.lureau@redhat.com> References: <20181221090410.27250-1-marcandre.lureau@redhat.com> <20181221090410.27250-18-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v7 17/28] compat: replace PC_COMPAT_2_3 & HW_COMPAT_2_3 macros List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau Cc: qemu-devel@nongnu.org, imammedo@redhat.com, ehabkost@redhat.com On Fri, 21 Dec 2018 13:03:59 +0400 Marc-Andr=C3=A9 Lureau wrote: > Use static arrays instead. I decided to rename the conflicting > pc_compat_2_3() function with pc_compat_2_3_fn(). >=20 > Suggested-by: Eduardo Habkost > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > include/hw/boards.h | 3 ++ > include/hw/compat.h | 39 -------------------- > include/hw/i386/pc.h | 88 ++------------------------------------------ > hw/core/machine.c | 41 +++++++++++++++++++++ > hw/i386/pc.c | 86 +++++++++++++++++++++++++++++++++++++++++++ > hw/i386/pc_piix.c | 13 +++---- > hw/ppc/spapr.c | 2 +- > 7 files changed, 139 insertions(+), 133 deletions(-) Reviewed-by: Cornelia Huck