From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gaMow-000311-3I for qemu-devel@nongnu.org; Fri, 21 Dec 2018 10:34:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gaMos-0007o0-3i for qemu-devel@nongnu.org; Fri, 21 Dec 2018 10:34:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58256) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gaMor-0007nq-UI for qemu-devel@nongnu.org; Fri, 21 Dec 2018 10:34:34 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3A9167AEB2 for ; Fri, 21 Dec 2018 15:34:33 +0000 (UTC) Date: Fri, 21 Dec 2018 16:34:26 +0100 From: Cornelia Huck Message-ID: <20181221163426.1e0bbb35.cohuck@redhat.com> In-Reply-To: <20181221090410.27250-26-marcandre.lureau@redhat.com> References: <20181221090410.27250-1-marcandre.lureau@redhat.com> <20181221090410.27250-26-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v7 25/28] qdev-props: remove errp from GlobalProperty List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau Cc: qemu-devel@nongnu.org, imammedo@redhat.com, ehabkost@redhat.com On Fri, 21 Dec 2018 13:04:07 +0400 Marc-Andr=C3=A9 Lureau wrote: > All qdev_prop_register_global() set &error_fatal for errp, except > '-rtc driftfix=3Dslew', which arguably should also use &error_fatal, as > otherwise failing to apply the property would only report a warning. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > Reviewed-by: Igor Mammedov > --- > include/hw/qdev-core.h | 6 ------ > hw/core/qdev-properties.c | 4 ++-- > qom/cpu.c | 1 - > target/i386/cpu.c | 1 - > target/sparc/cpu.c | 1 - > vl.c | 1 - > 6 files changed, 2 insertions(+), 12 deletions(-) >=20 > diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c > index 3467e0485c..a2d25d3d37 100644 > --- a/hw/core/qdev-properties.c > +++ b/hw/core/qdev-properties.c > @@ -1238,8 +1238,8 @@ void qdev_prop_set_globals(DeviceState *dev) > if (err !=3D NULL) { > error_prepend(&err, "can't apply global %s.%s=3D%s: ", > prop->driver, prop->property, prop->value); > - if (!dev->hotplugged && prop->errp) { > - error_propagate(prop->errp, err); > + if (!dev->hotplugged) { > + error_propagate(&error_fatal, err); Might want to add a comment to this function that any error is fatal for non-hotplugged devices. > } else { > warn_report_err(err); > } Reviewed-by: Cornelia Huck