qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: yuchenlin <npes87184@gmail.com>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com, qemu-block@nongnu.org,
	yuchenlin <npes87184@gmail.com>
Subject: [Qemu-devel] [PATCH v2 0/3] dmg: fixing reading in dmg
Date: Sun, 23 Dec 2018 10:59:36 +0800	[thread overview]
Message-ID: <20181223025939.15775-1-npes87184@gmail.com> (raw)

There are two bugs in dmg reading.

First, it may hang in binary search. this problem is solved by patch 1.
Second, because of lacking zero chunk table, reading zero sector will
return EIO. thie problem is solved by patch 2 and 3.

Thanks

v1 - >v2:
* fix typos in patch 1
* add patch 2 and patch 3

yuchenlin (3):
  dmg: fix binary search
  dmg: use enumeration type instead of hard coding number
  dmg: don't skip zero chunk

 block/dmg.c | 25 +++++++++++++++----------
 1 file changed, 15 insertions(+), 10 deletions(-)

-- 
2.17.1

             reply	other threads:[~2018-12-23  3:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-23  2:59 yuchenlin [this message]
2018-12-23  2:59 ` [Qemu-devel] [PATCH v2 1/3] dmg: fix binary search yuchenlin
2018-12-24 15:27   ` Julio Faracco
2019-01-02 11:49   ` Stefan Hajnoczi
2019-01-02 12:20     ` 林育辰
2019-01-03 10:09       ` Stefan Hajnoczi
2019-01-03 11:40         ` Yu-Chen Lin
2018-12-23  2:59 ` [Qemu-devel] [PATCH v2 2/3] dmg: use enumeration type instead of hard coding number yuchenlin
2018-12-24 15:28   ` Julio Faracco
2019-01-02 11:49   ` Stefan Hajnoczi
2018-12-23  2:59 ` [Qemu-devel] [PATCH v2 3/3] dmg: don't skip zero chunk yuchenlin
2018-12-24 15:28   ` Julio Faracco
2019-01-02 12:40   ` Stefan Hajnoczi
2018-12-24 15:26 ` [Qemu-devel] [Qemu-block] [PATCH v2 0/3] dmg: fixing reading in dmg Julio Faracco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181223025939.15775-1-npes87184@gmail.com \
    --to=npes87184@gmail.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).