From: Yang Zhong <yang.zhong@intel.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, sameo@linux.intel.com, ehabkost@redhat.com,
peter.maydell@linaro.org, thuth@redhat.com, yang.zhong@intel.com
Subject: [Qemu-devel] [RFC PATCH 04/25] minikconfig: add AST
Date: Thu, 27 Dec 2018 14:33:58 +0800 [thread overview]
Message-ID: <20181227063419.12981-5-yang.zhong@intel.com> (raw)
In-Reply-To: <20181227063419.12981-1-yang.zhong@intel.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Add Python classes that represent the Kconfig abstract syntax tree.
The abstract syntax tree is stored as a list of clauses. For example:
config FOO
depends on BAR
select BAZ
is represented as three clauses:
FOO depends on BAR
FOO default n
select BAZ if FOO
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
scripts/minikconf.py | 116 ++++++++++++++++++++++++++++++++++++-------
1 file changed, 98 insertions(+), 18 deletions(-)
diff --git a/scripts/minikconf.py b/scripts/minikconf.py
index 9e33d80514..f1851c3570 100644
--- a/scripts/minikconf.py
+++ b/scripts/minikconf.py
@@ -26,11 +26,84 @@ __all__ = [ 'KconfigParserError', 'KconfigData', 'KconfigParser' ]
# -------------------------------------------
class KconfigData:
+ class Expr:
+ def __and__(self, rhs):
+ return KconfigData.AND(self, rhs)
+ def __or__(self, rhs):
+ return KconfigData.OR(self, rhs)
+ def __invert__(self):
+ return KconfigData.NOT(self)
+
+ class AND(Expr):
+ def __init__(self, lhs, rhs):
+ self.lhs = lhs
+ self.rhs = rhs
+ def __str__(self):
+ return "(%s && %s)" % (self.lhs, self.rhs)
+
+ class OR(Expr):
+ def __init__(self, lhs, rhs):
+ self.lhs = lhs
+ self.rhs = rhs
+ def __str__(self):
+ return "(%s || %s)" % (self.lhs, self.rhs)
+
+ class NOT(Expr):
+ def __init__(self, lhs):
+ self.lhs = lhs
+ def __str__(self):
+ return "!%s" % (self.lhs)
+
+ class Var(Expr):
+ def __init__(self, name):
+ self.name = name
+ self.value = None
+ def __str__(self):
+ return self.name
+
+ class Clause:
+ def __init__(self, dest):
+ self.dest = dest
+
+ class AssignmentClause(Clause):
+ def __init__(self, dest, value):
+ KconfigData.Clause.__init__(self, dest)
+ self.value = value
+ def __str__(self):
+ return "%s=%s" % (self.dest, 'y' if self.value else 'n')
+
+ class DefaultClause(Clause):
+ def __init__(self, dest, value, cond=None):
+ KconfigData.Clause.__init__(self, dest)
+ self.value = value
+ self.cond = cond
+ def __str__(self):
+ value = 'y' if self.value else 'n'
+ if self.cond is None:
+ return "config %s default %s" % (self.dest, value)
+ else:
+ return "config %s default %s if %s" % (self.dest, value, self.cond)
+
+ class DependsOnClause(Clause):
+ def __init__(self, dest, expr):
+ KconfigData.Clause.__init__(self, dest)
+ self.expr = expr
+ def __str__(self):
+ return "config %s depends on %s" % (self.dest, self.expr)
+
+ class SelectClause(Clause):
+ def __init__(self, dest, cond):
+ KconfigData.Clause.__init__(self, dest)
+ self.cond = cond
+ def __str__(self):
+ return "select %s if %s" % (self.dest, self.cond)
+
def __init__(self):
self.previously_included = []
self.incl_info = None
self.defined_vars = set()
- self.referenced_vars = set()
+ self.referenced_vars = dict()
+ self.clauses = list()
# semantic analysis -------------
@@ -48,26 +121,28 @@ class KconfigData:
if (var in self.defined_vars):
raise Exception('variable "' + var + '" defined twice')
- self.defined_vars.add(var)
+ self.defined_vars.add(var.name)
# var is a string with the variable's name.
- #
- # For now this just returns the variable's name itself.
def do_var(self, var):
- self.referenced_vars.add(var)
- return var
+ if (var in self.referenced_vars):
+ return self.referenced_vars[var]
+
+ var_obj = self.referenced_vars[var] = KconfigData.Var(var)
+ return var_obj
def do_assignment(self, var, val):
- pass
+ self.clauses.append(KconfigData.AssignmentClause(var, val))
def do_default(self, var, val, cond=None):
- pass
+ self.clauses.append(KconfigData.DefaultClause(var, val, cond))
def do_depends_on(self, var, expr):
- pass
+ self.clauses.append(KconfigData.DependsOnClause(var, expr))
def do_select(self, var, symbol, cond=None):
- pass
+ cond = (cond & var) if not (cond is None) else var
+ self.clauses.append(KconfigData.SelectClause(symbol, cond))
# -------------------------------------------
# KconfigParser implements a recursive descent parser for (simplified)
@@ -229,31 +304,34 @@ class KconfigParser:
def parse_primary(self):
if self.tok == TOK_NOT:
self.get_token()
- self.parse_primary()
+ val = ~self.parse_primary()
elif self.tok == TOK_LPAREN:
self.get_token()
- self.parse_expr()
+ val = self.parse_expr()
if self.tok != TOK_RPAREN:
raise KconfigParserError(self, 'Expected ")"')
self.get_token()
elif self.tok == TOK_ID:
- self.parse_var()
+ val = self.parse_var()
else:
raise KconfigParserError(self, 'Expected "!" or "(" or identifier')
+ return val
# disj: primary (OR primary)*
def parse_disj(self):
- self.parse_primary()
+ lhs = self.parse_primary()
while self.tok == TOK_OR:
self.get_token()
- self.parse_primary()
+ lhs = lhs | self.parse_primary()
+ return lhs
# expr: disj (AND disj)*
def parse_expr(self):
- self.parse_disj()
+ lhs = self.parse_disj()
while self.tok == TOK_AND:
self.get_token()
- self.parse_disj()
+ lhs = lhs & self.parse_disj()
+ return lhs
# condition: IF expr
# | empty
@@ -422,4 +500,6 @@ class KconfigParser:
if __name__ == '__main__':
fname = len(sys.argv) > 1 and sys.argv[1] or 'Kconfig.test'
- KconfigParser.parse(open(fname, 'r'))
+ data = KconfigParser.parse(open(fname, 'r'))
+ for i in data.clauses:
+ print i
--
2.17.1
next prev parent reply other threads:[~2018-12-27 6:35 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 6:33 [Qemu-devel] [RFC PATCH 00/25] Support Kconfig in QEMU Yang Zhong
2018-12-27 6:33 ` [Qemu-devel] [RFC PATCH 01/25] build: actually use CONFIG_PAM Yang Zhong
2019-01-03 14:15 ` Thomas Huth
2019-01-07 11:29 ` Yang Zhong
2018-12-27 6:33 ` [Qemu-devel] [RFC PATCH 02/25] hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards Yang Zhong
2019-01-03 14:30 ` Thomas Huth
2018-12-27 6:33 ` [Qemu-devel] [RFC PATCH 03/25] minikconfig: add parser skeleton Yang Zhong
2019-01-04 13:36 ` Paolo Bonzini
2018-12-27 6:33 ` Yang Zhong [this message]
2019-01-04 14:13 ` [Qemu-devel] [RFC PATCH 04/25] minikconfig: add AST Paolo Bonzini
2019-01-07 12:06 ` Yang Zhong
2018-12-27 6:33 ` [Qemu-devel] [RFC PATCH 05/25] minikconfig: add semantic analysis Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 06/25] hw/display: make edid configurable Yang Zhong
2019-01-03 14:49 ` Thomas Huth
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 07/25] kconfig: introduce kconfig files Yang Zhong
2019-01-03 15:04 ` Thomas Huth
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 08/25] build: switch to Kconfig Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 09/25] ide: express dependencies with Kconfig Yang Zhong
2019-01-03 15:47 ` Thomas Huth
2019-01-08 5:22 ` Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 10/25] build: convert pci.mak to Kconfig Yang Zhong
2019-01-03 16:06 ` Thomas Huth
2019-01-08 5:58 ` Yang Zhong
2019-01-04 13:48 ` Thomas Huth
2019-01-08 7:20 ` Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 11/25] build: convert sound.mak " Yang Zhong
2019-01-04 13:26 ` Thomas Huth
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 12/25] build: convert usb.mak " Yang Zhong
2019-01-04 13:31 ` Thomas Huth
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 13/25] scsi: express dependencies with Kconfig Yang Zhong
2019-01-04 13:38 ` Paolo Bonzini
2019-01-08 7:32 ` Yang Zhong
2019-01-04 13:39 ` Thomas Huth
2019-01-08 8:04 ` Yang Zhong
2019-01-08 11:42 ` Paolo Bonzini
2019-01-11 3:08 ` Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 14/25] bluetooth: " Yang Zhong
2019-01-04 13:41 ` Thomas Huth
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 15/25] isa: express dependencies with kconfig Yang Zhong
2019-01-04 13:55 ` Thomas Huth
2019-01-08 9:08 ` Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 16/25] i386: express dependencies with Kconfig Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 17/25] i2c: " Yang Zhong
2019-01-04 15:30 ` Thomas Huth
2019-01-08 9:15 ` Yang Zhong
2019-01-08 11:46 ` Paolo Bonzini
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 18/25] ptimer: " Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 19/25] edid: express dependencies with kconfig Yang Zhong
2019-01-04 15:35 ` Thomas Huth
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 20/25] hyperv: " Yang Zhong
2019-01-04 15:38 ` Thomas Huth
2019-01-04 19:50 ` Paolo Bonzini
2019-01-08 10:38 ` Yang Zhong
2019-01-08 10:35 ` Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 21/25] virtio: make virtio dependencies with Kconfig Yang Zhong
2019-01-04 19:54 ` Thomas Huth
2019-01-08 10:45 ` Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 22/25] i386-softmmu.mak: remove all CONFIG_* except boards definitions Yang Zhong
2019-01-04 13:59 ` Paolo Bonzini
2019-01-08 10:53 ` Yang Zhong
2019-01-08 11:48 ` Paolo Bonzini
2019-01-11 2:22 ` Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 23/25] x86_64-softmmu.mak: remove i386-softmmu.mak include Yang Zhong
2019-01-04 19:58 ` Thomas Huth
2019-01-08 10:55 ` Yang Zhong
2019-01-05 15:32 ` Peter Maydell
2019-01-08 10:58 ` Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 24/25] minikconf: implement allyesconfig, allnoconfig, randconfig, defconfig Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 25/25] Makefile: only support defconfig Yang Zhong
2019-01-04 14:02 ` [Qemu-devel] [RFC PATCH 00/25] Support Kconfig in QEMU Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181227063419.12981-5-yang.zhong@intel.com \
--to=yang.zhong@intel.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sameo@linux.intel.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).