From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gcPUu-00059F-4f for qemu-devel@nongnu.org; Thu, 27 Dec 2018 01:50:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gcPUo-0005wT-8k for qemu-devel@nongnu.org; Thu, 27 Dec 2018 01:50:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42522) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gcPUk-0005sT-N7 for qemu-devel@nongnu.org; Thu, 27 Dec 2018 01:50:16 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CAAFB7FDEB for ; Thu, 27 Dec 2018 06:50:12 +0000 (UTC) Date: Thu, 27 Dec 2018 07:50:03 +0100 From: Igor Mammedov Message-ID: <20181227075003.64b3ee63@Igors-MacBook-Pro.local> In-Reply-To: <20181221090410.27250-16-marcandre.lureau@redhat.com> References: <20181221090410.27250-1-marcandre.lureau@redhat.com> <20181221090410.27250-16-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v7 15/28] compat: replace PC_COMPAT_2_5 & HW_COMPAT_2_5 macros List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Marc-Andr=C3=A9?= Lureau Cc: qemu-devel@nongnu.org, ehabkost@redhat.com On Fri, 21 Dec 2018 13:03:57 +0400 Marc-Andr=C3=A9 Lureau wrote: > Use static arrays instead. >=20 > Suggested-by: Eduardo Habkost > Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Igor Mammedov > --- > include/hw/boards.h | 3 +++ > include/hw/compat.h | 24 ------------------------ > include/hw/i386/pc.h | 4 ++-- > hw/core/machine.c | 26 ++++++++++++++++++++++++++ > hw/i386/pc.c | 3 +++ > hw/i386/pc_piix.c | 6 ++---- > hw/i386/pc_q35.c | 6 ++---- > hw/ppc/spapr.c | 2 +- > hw/s390x/s390-virtio-ccw.c | 6 +----- > 9 files changed, 40 insertions(+), 40 deletions(-) >=20 > diff --git a/include/hw/boards.h b/include/hw/boards.h > index a9d413cdb7..36e1269eb1 100644 > --- a/include/hw/boards.h > +++ b/include/hw/boards.h > @@ -314,4 +314,7 @@ extern const size_t hw_compat_2_7_len; > extern GlobalProperty hw_compat_2_6[]; > extern const size_t hw_compat_2_6_len; > =20 > +extern GlobalProperty hw_compat_2_5[]; > +extern const size_t hw_compat_2_5_len; > + > #endif > diff --git a/include/hw/compat.h b/include/hw/compat.h > index c744233fb6..a6eced34c6 100644 > --- a/include/hw/compat.h > +++ b/include/hw/compat.h > @@ -1,30 +1,6 @@ > #ifndef HW_COMPAT_H > #define HW_COMPAT_H > =20 > -#define HW_COMPAT_2_5 \ > - {\ > - .driver =3D "isa-fdc",\ > - .property =3D "fallback",\ > - .value =3D "144",\ > - },{\ > - .driver =3D "pvscsi",\ > - .property =3D "x-old-pci-configuration",\ > - .value =3D "on",\ > - },{\ > - .driver =3D "pvscsi",\ > - .property =3D "x-disable-pcie",\ > - .value =3D "on",\ > - },\ > - {\ > - .driver =3D "vmxnet3",\ > - .property =3D "x-old-msi-offsets",\ > - .value =3D "on",\ > - },{\ > - .driver =3D "vmxnet3",\ > - .property =3D "x-disable-pcie",\ > - .value =3D "on",\ > - }, > - > #define HW_COMPAT_2_4 \ > {\ > .driver =3D "virtio-blk-device",\ > diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h > index ca62def2c9..9a32031f25 100644 > --- a/include/hw/i386/pc.h > +++ b/include/hw/i386/pc.h > @@ -321,8 +321,8 @@ extern const size_t pc_compat_2_7_len; > extern GlobalProperty pc_compat_2_6[]; > extern const size_t pc_compat_2_6_len; > =20 > -#define PC_COMPAT_2_5 \ > - HW_COMPAT_2_5 > +extern GlobalProperty pc_compat_2_5[]; > +extern const size_t pc_compat_2_5_len; > =20 > /* Helper for setting model-id for CPU models that changed model-id > * depending on QEMU versions up to QEMU 2.4. > diff --git a/hw/core/machine.c b/hw/core/machine.c > index 5f1af02c86..1022b538a5 100644 > --- a/hw/core/machine.c > +++ b/hw/core/machine.c > @@ -200,6 +200,32 @@ GlobalProperty hw_compat_2_6[] =3D { > }; > const size_t hw_compat_2_6_len =3D G_N_ELEMENTS(hw_compat_2_6); > =20 > +GlobalProperty hw_compat_2_5[] =3D { > + { > + .driver =3D "isa-fdc", > + .property =3D "fallback", > + .value =3D "144", > + },{ > + .driver =3D "pvscsi", > + .property =3D "x-old-pci-configuration", > + .value =3D "on", > + },{ > + .driver =3D "pvscsi", > + .property =3D "x-disable-pcie", > + .value =3D "on", > + }, > + { > + .driver =3D "vmxnet3", > + .property =3D "x-old-msi-offsets", > + .value =3D "on", > + },{ > + .driver =3D "vmxnet3", > + .property =3D "x-disable-pcie", > + .value =3D "on", > + }, > +}; > +const size_t hw_compat_2_5_len =3D G_N_ELEMENTS(hw_compat_2_5); > + > static char *machine_get_accel(Object *obj, Error **errp) > { > MachineState *ms =3D MACHINE(obj); > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index f719115f17..ac54c2e39d 100644 > --- a/hw/i386/pc.c > +++ b/hw/i386/pc.c > @@ -275,6 +275,9 @@ GlobalProperty pc_compat_2_6[] =3D { > }; > const size_t pc_compat_2_6_len =3D G_N_ELEMENTS(pc_compat_2_6); > =20 > +GlobalProperty pc_compat_2_5[] =3D {}; > +const size_t pc_compat_2_5_len =3D G_N_ELEMENTS(pc_compat_2_5); > + > void gsi_handler(void *opaque, int n, int level) > { > GSIState *s =3D opaque; > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index 5f3dc8a809..4f5168534a 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -539,14 +539,12 @@ DEFINE_I440FX_MACHINE(v2_6, "pc-i440fx-2.6", NULL, > static void pc_i440fx_2_5_machine_options(MachineClass *m) > { > PCMachineClass *pcmc =3D PC_MACHINE_CLASS(m); > - static GlobalProperty compat[] =3D { > - PC_COMPAT_2_5 > - }; > =20 > pc_i440fx_2_6_machine_options(m); > pcmc->save_tsc_khz =3D false; > m->legacy_fw_cfg_order =3D 1; > - compat_props_add(m->compat_props, compat, G_N_ELEMENTS(compat)); > + compat_props_add(m->compat_props, hw_compat_2_5, hw_compat_2_5_len); > + compat_props_add(m->compat_props, pc_compat_2_5, pc_compat_2_5_len); > } > =20 > DEFINE_I440FX_MACHINE(v2_5, "pc-i440fx-2.5", NULL, > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > index 063df36cad..a33d5d3610 100644 > --- a/hw/i386/pc_q35.c > +++ b/hw/i386/pc_q35.c > @@ -424,14 +424,12 @@ DEFINE_Q35_MACHINE(v2_6, "pc-q35-2.6", NULL, > static void pc_q35_2_5_machine_options(MachineClass *m) > { > PCMachineClass *pcmc =3D PC_MACHINE_CLASS(m); > - static GlobalProperty compat[] =3D { > - PC_COMPAT_2_5 > - }; > =20 > pc_q35_2_6_machine_options(m); > pcmc->save_tsc_khz =3D false; > m->legacy_fw_cfg_order =3D 1; > - compat_props_add(m->compat_props, compat, G_N_ELEMENTS(compat)); > + compat_props_add(m->compat_props, hw_compat_2_5, hw_compat_2_5_len); > + compat_props_add(m->compat_props, pc_compat_2_5, pc_compat_2_5_len); > } > =20 > DEFINE_Q35_MACHINE(v2_5, "pc-q35-2.5", NULL, > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 797f480564..c808ec90f0 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -4226,7 +4226,6 @@ static void spapr_machine_2_5_class_options(Machine= Class *mc) > { > sPAPRMachineClass *smc =3D SPAPR_MACHINE_CLASS(mc); > static GlobalProperty compat[] =3D { > - HW_COMPAT_2_5 > { > .driver =3D "spapr-vlan", > .property =3D "use-rx-buffer-pools", > @@ -4236,6 +4235,7 @@ static void spapr_machine_2_5_class_options(Machine= Class *mc) > =20 > spapr_machine_2_6_class_options(mc); > smc->use_ohci_by_default =3D true; > + compat_props_add(mc->compat_props, hw_compat_2_5, hw_compat_2_5_len); > compat_props_add(mc->compat_props, compat, G_N_ELEMENTS(compat)); > } > =20 > diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c > index 6137c97875..1ab53a1332 100644 > --- a/hw/s390x/s390-virtio-ccw.c > +++ b/hw/s390x/s390-virtio-ccw.c > @@ -836,12 +836,8 @@ static void ccw_machine_2_5_instance_options(Machine= State *machine) > =20 > static void ccw_machine_2_5_class_options(MachineClass *mc) > { > - static GlobalProperty compat[] =3D { > - HW_COMPAT_2_5 > - }; > - > ccw_machine_2_6_class_options(mc); > - compat_props_add(mc->compat_props, compat, G_N_ELEMENTS(compat)); > + compat_props_add(mc->compat_props, hw_compat_2_5, hw_compat_2_5_len); > } > DEFINE_CCW_MACHINE(2_5, "2.5", false); > =20