qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH v7 20/28] include: remove compat.h
Date: Thu, 27 Dec 2018 07:56:01 +0100	[thread overview]
Message-ID: <20181227075601.22f7f43f@Igors-MacBook-Pro.local> (raw)
In-Reply-To: <20181221090410.27250-21-marcandre.lureau@redhat.com>

On Fri, 21 Dec 2018 13:04:02 +0400
Marc-André Lureau <marcandre.lureau@redhat.com> wrote:

> The header is now empty.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  include/hw/compat.h        | 4 ----
>  include/hw/i386/pc.h       | 1 -
>  hw/arm/virt.c              | 1 -
>  hw/ppc/spapr.c             | 1 -
>  hw/s390x/s390-virtio-ccw.c | 1 -
>  5 files changed, 8 deletions(-)
>  delete mode 100644 include/hw/compat.h
> 
> diff --git a/include/hw/compat.h b/include/hw/compat.h
> deleted file mode 100644
> index b2d0bdd599..0000000000
> --- a/include/hw/compat.h
> +++ /dev/null
> @@ -1,4 +0,0 @@
> -#ifndef HW_COMPAT_H
> -#define HW_COMPAT_H
> -
> -#endif /* HW_COMPAT_H */
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 784ea7a92c..6b7bf334cd 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -13,7 +13,6 @@
>  #include "qemu/bitmap.h"
>  #include "sysemu/sysemu.h"
>  #include "hw/pci/pci.h"
> -#include "hw/compat.h"
>  #include "hw/mem/pc-dimm.h"
>  #include "hw/mem/nvdimm.h"
>  #include "hw/acpi/acpi_dev_interface.h"
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 5fe2eebb02..9570f06f04 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -43,7 +43,6 @@
>  #include "sysemu/numa.h"
>  #include "sysemu/sysemu.h"
>  #include "sysemu/kvm.h"
> -#include "hw/compat.h"
>  #include "hw/loader.h"
>  #include "exec/address-spaces.h"
>  #include "qemu/bitops.h"
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 1c5b0e40b1..653a4528ac 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -70,7 +70,6 @@
>  #include "hw/nmi.h"
>  #include "hw/intc/intc.h"
>  
> -#include "hw/compat.h"
>  #include "qemu/cutils.h"
>  #include "hw/ppc/spapr_cpu_core.h"
>  #include "hw/mem/memory-device.h"
> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
> index bf5f2f463c..c737507053 100644
> --- a/hw/s390x/s390-virtio-ccw.c
> +++ b/hw/s390x/s390-virtio-ccw.c
> @@ -28,7 +28,6 @@
>  #include "hw/s390x/storage-keys.h"
>  #include "hw/s390x/storage-attributes.h"
>  #include "hw/s390x/event-facility.h"
> -#include "hw/compat.h"
>  #include "ipl.h"
>  #include "hw/s390x/s390-virtio-ccw.h"
>  #include "hw/s390x/css-bridge.h"

  parent reply	other threads:[~2018-12-27  6:56 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-21  9:03 [Qemu-devel] [PATCH v7 00/28] Generalize machine compatibility properties Marc-André Lureau
2018-12-21  9:03 ` [Qemu-devel] [PATCH v7 01/28] hw: apply accel compat properties without touching globals Marc-André Lureau
2018-12-21 11:58   ` Cornelia Huck
2018-12-21  9:03 ` [Qemu-devel] [PATCH v7 02/28] machines: replace COMPAT define with a static array Marc-André Lureau
2018-12-21 12:33   ` Cornelia Huck
2018-12-21 14:17   ` Igor Mammedov
2018-12-21  9:03 ` [Qemu-devel] [PATCH v7 03/28] hw: apply machine compat properties without touching globals Marc-André Lureau
2018-12-21 12:38   ` Cornelia Huck
2018-12-21 14:20   ` Igor Mammedov
2018-12-21  9:03 ` [Qemu-devel] [PATCH v7 04/28] machine: move compat properties out of globals Marc-André Lureau
2018-12-21 12:44   ` Cornelia Huck
2018-12-21 14:21   ` Igor Mammedov
2018-12-21  9:03 ` [Qemu-devel] [PATCH v7 05/28] hw: remove SET_MACHINE_COMPAT Marc-André Lureau
2018-12-21 12:44   ` Cornelia Huck
2018-12-21 14:22   ` Igor Mammedov
2018-12-21  9:03 ` [Qemu-devel] [PATCH v7 06/28] compat: replace PC_COMPAT_3_1 & HW_COMPAT_3_1 macros Marc-André Lureau
2018-12-21 12:47   ` Cornelia Huck
2018-12-27  6:35   ` Igor Mammedov
2018-12-21  9:03 ` [Qemu-devel] [PATCH v7 07/28] compat: replace PC_COMPAT_3_0 & HW_COMPAT_3_0 macros Marc-André Lureau
2018-12-21 12:50   ` Cornelia Huck
2018-12-27  6:37   ` Igor Mammedov
2018-12-21  9:03 ` [Qemu-devel] [PATCH v7 08/28] compat: replace PC_COMPAT_2_12 & HW_COMPAT_2_12 macros Marc-André Lureau
2018-12-21 12:52   ` Cornelia Huck
2018-12-27  6:39   ` Igor Mammedov
2018-12-21  9:03 ` [Qemu-devel] [PATCH v7 09/28] compat: replace PC_COMPAT_2_11 & HW_COMPAT_2_11 macros Marc-André Lureau
2018-12-21 12:53   ` Cornelia Huck
2018-12-27  6:40   ` Igor Mammedov
2018-12-21  9:03 ` [Qemu-devel] [PATCH v7 10/28] compat: replace PC_COMPAT_2_10 & HW_COMPAT_2_10 macros Marc-André Lureau
2018-12-21 12:55   ` Cornelia Huck
2018-12-27  6:41   ` Igor Mammedov
2018-12-21  9:03 ` [Qemu-devel] [PATCH v7 11/28] compat: replace PC_COMPAT_2_9 & HW_COMPAT_2_9 macros Marc-André Lureau
2018-12-21 12:56   ` Cornelia Huck
2018-12-27  6:44   ` Igor Mammedov
2018-12-21  9:03 ` [Qemu-devel] [PATCH v7 12/28] compat: replace PC_COMPAT_2_8 & HW_COMPAT_2_8 macros Marc-André Lureau
2018-12-21 12:58   ` Cornelia Huck
2018-12-27  6:45   ` Igor Mammedov
2018-12-21  9:03 ` [Qemu-devel] [PATCH v7 13/28] compat: replace PC_COMPAT_2_7 & HW_COMPAT_2_7 macros Marc-André Lureau
2018-12-21 13:00   ` Cornelia Huck
2018-12-27  6:47   ` Igor Mammedov
2018-12-21  9:03 ` [Qemu-devel] [PATCH v7 14/28] compat: replace PC_COMPAT_2_6 & HW_COMPAT_2_6 macros Marc-André Lureau
2018-12-21 13:03   ` Cornelia Huck
2018-12-27  6:48   ` Igor Mammedov
2018-12-21  9:03 ` [Qemu-devel] [PATCH v7 15/28] compat: replace PC_COMPAT_2_5 & HW_COMPAT_2_5 macros Marc-André Lureau
2018-12-21 13:04   ` Cornelia Huck
2018-12-27  6:50   ` Igor Mammedov
2018-12-21  9:03 ` [Qemu-devel] [PATCH v7 16/28] compat: replace PC_COMPAT_2_4 & HW_COMPAT_2_4 macros Marc-André Lureau
2018-12-21 13:05   ` Cornelia Huck
2018-12-27  6:51   ` Igor Mammedov
2018-12-21  9:03 ` [Qemu-devel] [PATCH v7 17/28] compat: replace PC_COMPAT_2_3 & HW_COMPAT_2_3 macros Marc-André Lureau
2018-12-21 13:07   ` Cornelia Huck
2018-12-27  6:52   ` Igor Mammedov
2018-12-21  9:04 ` [Qemu-devel] [PATCH v7 18/28] compat: replace PC_COMPAT_2_2 & HW_COMPAT_2_2 macros Marc-André Lureau
2018-12-21 13:08   ` Cornelia Huck
2018-12-27  6:53   ` Igor Mammedov
2018-12-21  9:04 ` [Qemu-devel] [PATCH v7 19/28] compat: replace PC_COMPAT_2_1 & HW_COMPAT_2_1 macros Marc-André Lureau
2018-12-21 13:09   ` Cornelia Huck
2018-12-27  6:54   ` Igor Mammedov
2018-12-21  9:04 ` [Qemu-devel] [PATCH v7 20/28] include: remove compat.h Marc-André Lureau
2018-12-21 13:10   ` Cornelia Huck
2018-12-27  6:56   ` Igor Mammedov [this message]
2018-12-21  9:04 ` [Qemu-devel] [PATCH v7 21/28] compat: remove remaining PC_COMPAT macros Marc-André Lureau
2018-12-21 13:12   ` Cornelia Huck
2018-12-27  6:58   ` Igor Mammedov
2018-12-21  9:04 ` [Qemu-devel] [PATCH v7 22/28] qdev: make a separate helper function to apply compat properties Marc-André Lureau
2018-12-21 14:38   ` Igor Mammedov
2018-12-21 15:25   ` Cornelia Huck
2018-12-21  9:04 ` [Qemu-devel] [PATCH v7 23/28] qdev: all globals are now user-provided Marc-André Lureau
2018-12-21 15:26   ` Cornelia Huck
2018-12-21  9:04 ` [Qemu-devel] [PATCH v7 24/28] qdev-props: convert global_props to GPtrArray Marc-André Lureau
2018-12-21 15:28   ` Cornelia Huck
2018-12-21  9:04 ` [Qemu-devel] [PATCH v7 25/28] qdev-props: remove errp from GlobalProperty Marc-André Lureau
2018-12-21 15:34   ` Cornelia Huck
2019-01-04 10:57     ` Marc-André Lureau
2019-01-04 11:04       ` Cornelia Huck
2018-12-21  9:04 ` [Qemu-devel] [PATCH v7 26/28] qdev-props: call object_apply_global_props() Marc-André Lureau
2018-12-21 15:35   ` Cornelia Huck
2018-12-21  9:04 ` [Qemu-devel] [PATCH v7 27/28] arm: replace instance_post_init() Marc-André Lureau
2018-12-21  9:04 ` [Qemu-devel] [PATCH v7 28/28] hostmem: use object id for memory region name with >= 4.0 Marc-André Lureau
2019-01-04 11:42 ` [Qemu-devel] [PATCH v7 00/28] Generalize machine compatibility properties Marc-André Lureau
2019-01-04 16:16   ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181227075601.22f7f43f@Igors-MacBook-Pro.local \
    --to=imammedo@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).