* [Qemu-devel] [PATCH] dmg: Fixing wrong dmg block type value for block terminator.
@ 2018-12-28 14:50 Julio Faracco
2019-01-02 8:49 ` [Qemu-devel] [Qemu-block] " yuchenlin
2019-01-02 14:09 ` [Qemu-devel] " Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Julio Faracco @ 2018-12-28 14:50 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, stefanha, kwolf, mreitz, qemu-block
This is a trivial patch to fix a wrong value for block terminator.
The old value was 0x7fffffff which is wrong. It was not affecting the
code because QEMU dmg block is not handling block terminator right now.
Neverthless, it should be fixed.
Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
---
block/dmg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/dmg.c b/block/dmg.c
index 50e91aef6d..2c806e3389 100644
--- a/block/dmg.c
+++ b/block/dmg.c
@@ -54,7 +54,7 @@ enum {
UDBZ,
ULFO,
UDCM = 0x7ffffffe, /* Comments */
- UDLE /* Last Entry */
+ UDLE = 0xffffffff /* Last Entry */
};
static int dmg_probe(const uint8_t *buf, int buf_size, const char *filename)
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [Qemu-block] [PATCH] dmg: Fixing wrong dmg block type value for block terminator.
2018-12-28 14:50 [Qemu-devel] [PATCH] dmg: Fixing wrong dmg block type value for block terminator Julio Faracco
@ 2019-01-02 8:49 ` yuchenlin
2019-01-02 14:09 ` [Qemu-devel] " Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: yuchenlin @ 2019-01-02 8:49 UTC (permalink / raw)
To: Julio Faracco
Cc: qemu-devel, qemu-trivial, kwolf, qemu-block, stefanha, mreitz,
Qemu-block
On 2018-12-28 22:50, Julio Faracco wrote:
> This is a trivial patch to fix a wrong value for block terminator.
> The old value was 0x7fffffff which is wrong. It was not affecting the
> code because QEMU dmg block is not handling block terminator right now.
> Neverthless, it should be fixed.
>
> Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
Reviewed-by: yuchenlin <yuchenlin@synology.com>
> ---
> block/dmg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/dmg.c b/block/dmg.c
> index 50e91aef6d..2c806e3389 100644
> --- a/block/dmg.c
> +++ b/block/dmg.c
> @@ -54,7 +54,7 @@ enum {
> UDBZ,
> ULFO,
> UDCM = 0x7ffffffe, /* Comments */
> - UDLE /* Last Entry */
> + UDLE = 0xffffffff /* Last Entry */
> };
>
> static int dmg_probe(const uint8_t *buf, int buf_size, const char
> *filename)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] dmg: Fixing wrong dmg block type value for block terminator.
2018-12-28 14:50 [Qemu-devel] [PATCH] dmg: Fixing wrong dmg block type value for block terminator Julio Faracco
2019-01-02 8:49 ` [Qemu-devel] [Qemu-block] " yuchenlin
@ 2019-01-02 14:09 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2019-01-02 14:09 UTC (permalink / raw)
To: Julio Faracco; +Cc: qemu-devel, qemu-trivial, kwolf, mreitz, qemu-block
[-- Attachment #1: Type: text/plain, Size: 551 bytes --]
On Fri, Dec 28, 2018 at 12:50:55PM -0200, Julio Faracco wrote:
> This is a trivial patch to fix a wrong value for block terminator.
> The old value was 0x7fffffff which is wrong. It was not affecting the
> code because QEMU dmg block is not handling block terminator right now.
> Neverthless, it should be fixed.
>
> Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
> ---
> block/dmg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-02 14:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-28 14:50 [Qemu-devel] [PATCH] dmg: Fixing wrong dmg block type value for block terminator Julio Faracco
2019-01-02 8:49 ` [Qemu-devel] [Qemu-block] " yuchenlin
2019-01-02 14:09 ` [Qemu-devel] " Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).