From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: fam@euphon.net, stefanha@redhat.com, jcody@redhat.com,
mreitz@redhat.com, kwolf@redhat.com, vsementsov@virtuozzo.com,
den@openvz.org, eblake@redhat.com, jsnow@redhat.com
Subject: [Qemu-devel] [PATCH v5 04/11] iotests: handle -f argument correctly for qemu_io_silent
Date: Sat, 29 Dec 2018 15:20:20 +0300 [thread overview]
Message-ID: <20181229122027.42245-5-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20181229122027.42245-1-vsementsov@virtuozzo.com>
Correctly rewrite default argument. After the patch, the function can
be used for other (not only default test-chosen) image format.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
tests/qemu-iotests/iotests.py | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 9595429fea..76877ad584 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -139,7 +139,12 @@ def qemu_io(*args):
def qemu_io_silent(*args):
'''Run qemu-io and return the exit code, suppressing stdout'''
- args = qemu_io_args + list(args)
+ if '-f' in qemu_io_args and '-f' in args:
+ ind = qemu_io_args.index('-f')
+ args = qemu_io_args[:ind] + qemu_io_args[ind+2:] + list(args)
+ else:
+ args = qemu_io_args + list(args)
+
exitcode = subprocess.call(args, stdout=open('/dev/null', 'w'))
if exitcode < 0:
sys.stderr.write('qemu-io received signal %i: %s\n' %
--
2.18.0
next prev parent reply other threads:[~2018-12-29 12:40 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-29 12:20 [Qemu-devel] [PATCH v5 00/11] backup-top filter driver for backup Vladimir Sementsov-Ogievskiy
2018-12-29 12:20 ` [Qemu-devel] [PATCH v5 01/11] block/backup: simplify backup_incremental_init_copy_bitmap Vladimir Sementsov-Ogievskiy
2019-01-14 13:10 ` Max Reitz
2019-01-14 13:13 ` Max Reitz
2019-01-14 14:01 ` Vladimir Sementsov-Ogievskiy
2019-01-14 14:13 ` Max Reitz
2019-01-14 14:48 ` Vladimir Sementsov-Ogievskiy
2019-01-16 13:05 ` Max Reitz
2019-01-23 8:20 ` Vladimir Sementsov-Ogievskiy
2019-01-23 13:19 ` Max Reitz
2019-01-23 14:36 ` Eric Blake
2019-01-24 14:20 ` Vladimir Sementsov-Ogievskiy
2018-12-29 12:20 ` [Qemu-devel] [PATCH v5 02/11] block/backup: move to copy_bitmap with granularity Vladimir Sementsov-Ogievskiy
2019-01-14 14:10 ` Max Reitz
2018-12-29 12:20 ` [Qemu-devel] [PATCH v5 03/11] block: improve should_update_child Vladimir Sementsov-Ogievskiy
2019-01-14 14:32 ` Max Reitz
2019-01-14 16:13 ` Vladimir Sementsov-Ogievskiy
2019-01-16 13:17 ` Max Reitz
2018-12-29 12:20 ` Vladimir Sementsov-Ogievskiy [this message]
2019-01-14 14:36 ` [Qemu-devel] [PATCH v5 04/11] iotests: handle -f argument correctly for qemu_io_silent Max Reitz
2018-12-29 12:20 ` [Qemu-devel] [PATCH v5 05/11] iotests: allow resume_drive by node name Vladimir Sementsov-Ogievskiy
2019-01-14 14:46 ` Max Reitz
2019-01-14 16:06 ` Vladimir Sementsov-Ogievskiy
2019-01-16 13:11 ` Max Reitz
2019-01-23 13:22 ` Vladimir Sementsov-Ogievskiy
2019-01-23 13:31 ` Vladimir Sementsov-Ogievskiy
2019-01-23 13:33 ` Max Reitz
2018-12-29 12:20 ` [Qemu-devel] [PATCH v5 06/11] iotests: prepare 055 to graph changes during backup job Vladimir Sementsov-Ogievskiy
2019-01-16 13:48 ` Max Reitz
2018-12-29 12:20 ` [Qemu-devel] [PATCH v5 07/11] block: introduce backup-top filter driver Vladimir Sementsov-Ogievskiy
2019-01-16 16:02 ` Max Reitz
2019-01-17 12:13 ` Vladimir Sementsov-Ogievskiy
2019-01-18 12:05 ` Max Reitz
2019-01-23 13:47 ` Vladimir Sementsov-Ogievskiy
2019-04-13 16:08 ` Vladimir Sementsov-Ogievskiy
2019-04-13 16:08 ` Vladimir Sementsov-Ogievskiy
2019-04-13 17:03 ` Vladimir Sementsov-Ogievskiy
2019-04-13 17:03 ` Vladimir Sementsov-Ogievskiy
2018-12-29 12:20 ` [Qemu-devel] [PATCH v5 08/11] block/io: refactor wait_serialising_requests Vladimir Sementsov-Ogievskiy
2019-01-16 16:18 ` Max Reitz
2018-12-29 12:20 ` [Qemu-devel] [PATCH v5 09/11] block: add lock/unlock range functions Vladimir Sementsov-Ogievskiy
2019-01-16 16:36 ` Max Reitz
2018-12-29 12:20 ` [Qemu-devel] [PATCH v5 10/11] block/backup: tiny refactor backup_job_create Vladimir Sementsov-Ogievskiy
2019-01-18 13:00 ` Max Reitz
2018-12-29 12:20 ` [Qemu-devel] [PATCH v5 11/11] block/backup: use backup-top instead of write notifiers Vladimir Sementsov-Ogievskiy
2019-01-18 14:56 ` Max Reitz
2019-01-28 11:29 ` Vladimir Sementsov-Ogievskiy
2019-01-28 15:59 ` Max Reitz
2019-01-28 16:44 ` Vladimir Sementsov-Ogievskiy
2019-01-28 16:53 ` Max Reitz
2019-01-28 17:14 ` Vladimir Sementsov-Ogievskiy
2019-01-28 17:40 ` Kevin Wolf
2019-01-28 19:00 ` Vladimir Sementsov-Ogievskiy
2019-01-23 15:26 ` [Qemu-devel] [PATCH v5 00/11] backup-top filter driver for backup no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181229122027.42245-5-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).