[Qemu-devel] [PATCH 0/2] buildsys: Disable qht-bench parallel test when using gprof

[Qemu-devel] [PATCH 0/2] buildsys: Disable qht-bench parallel test when using gprof

[Philippe Mathieu-Daudé]

Disable test-qht-par when using gprof, as this break Travis CI.

See: https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg01638.html

Philippe Mathieu-Daudé (2):
  configure: Let the TARGET_GPROF var use the regular 'y' for Yes
  tests: Disable qht-bench parallel test when using gprof

 configure              | 2 +-
 tests/Makefile.include | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

-- 
2.17.2

[Qemu-devel] [PATCH 1/2] configure: Let the TARGET_GPROF var use the regular 'y' for Yes

[Philippe Mathieu-Daudé]

All other variables are set using 'y', which is what the rules.mak
functions expect to parse.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 79375affc1..fa5c079f98 100755
--- a/configure
+++ b/configure
@@ -7470,7 +7470,7 @@ alpha)
 esac
 
 if test "$gprof" = "yes" ; then
-  echo "TARGET_GPROF=yes" >> $config_target_mak
+  echo "TARGET_GPROF=y" >> $config_target_mak
   if test "$target_linux_user" = "yes" ; then
     cflags="-p $cflags"
     ldflags="-p $ldflags"
-- 
2.17.2

[Qemu-devel] [PATCH 2/2] tests: Disable qht-bench parallel test when using gprof

[Philippe Mathieu-Daudé]

This test is failing on the Travis CI [*] since some time now,
disable it until it get fixed.

[*] https://travis-ci.org/qemu/qemu/builds/474821674

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 tests/Makefile.include | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/Makefile.include b/tests/Makefile.include
index 3f5a1d0c30..e764d8d2cb 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -88,7 +88,8 @@ check-unit-y += tests/test-rcu-simpleq$(EXESUF)
 check-unit-y += tests/test-rcu-tailq$(EXESUF)
 check-unit-y += tests/test-qdist$(EXESUF)
 check-unit-y += tests/test-qht$(EXESUF)
-check-unit-y += tests/test-qht-par$(EXESUF)
+# FIXME: {test-qht-par + gprof} often break on Travis CI
+check-unit-$(call lnot,$(TARGET_GPROF)) += tests/test-qht-par$(EXESUF)
 check-unit-y += tests/test-bitops$(EXESUF)
 check-unit-y += tests/test-bitcnt$(EXESUF)
 check-unit-y += tests/test-qdev-global-props$(EXESUF)
-- 
2.17.2

Re: [Qemu-devel] [PATCH 2/2] tests: Disable qht-bench parallel test when using gprof

[Philippe Mathieu-Daudé]

On Thu, Jan 3, 2019 at 3:29 PM Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> This test is failing on the Travis CI [*] since some time now,
> disable it until it get fixed.
>
> [*] https://travis-ci.org/qemu/qemu/builds/474821674
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  tests/Makefile.include | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 3f5a1d0c30..e764d8d2cb 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -88,7 +88,8 @@ check-unit-y += tests/test-rcu-simpleq$(EXESUF)
>  check-unit-y += tests/test-rcu-tailq$(EXESUF)
>  check-unit-y += tests/test-qdist$(EXESUF)
>  check-unit-y += tests/test-qht$(EXESUF)
> -check-unit-y += tests/test-qht-par$(EXESUF)
> +# FIXME: {test-qht-par + gprof} often break on Travis CI
> +check-unit-$(call lnot,$(TARGET_GPROF)) += tests/test-qht-par$(EXESUF)

Oops this is incorrect because check-unit isn't target but host, so
TARGET_GPROF can't be used.

>  check-unit-y += tests/test-bitops$(EXESUF)
>  check-unit-y += tests/test-bitcnt$(EXESUF)
>  check-unit-y += tests/test-qdev-global-props$(EXESUF)
> --
> 2.17.2
>