qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: jim@groklearning.com, jusual@mail.ru, qemu-arm@nongnu.org,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Steffen Gortz" <qemu.ml@steffen-goertz.de>,
	"Joel Stanley" <joel@jms.id.au>,
	"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH] Revert "armv7m: Guard against no -kernel argument"
Date: Thu,  3 Jan 2019 14:41:24 +0000	[thread overview]
Message-ID: <20190103144124.18917-1-stefanha@redhat.com> (raw)

This reverts commit 01fd41ab3fb69971c24a69ed49cde96086d81278.

The generic loader device (-device loader,file=kernel.bin) can be used
to load a kernel instead of the -kernel option.  Some boards have flash
memory (pflash) that is set via the -pflash or -drive options.

Allow starting QEMU without the -kernel option to accommodate these
scenarios.

Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/arm/armv7m.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c
index 4bf9131b81..f444652830 100644
--- a/hw/arm/armv7m.c
+++ b/hw/arm/armv7m.c
@@ -285,11 +285,6 @@ void armv7m_load_kernel(ARMCPU *cpu, const char *kernel_filename, int mem_size)
     big_endian = 0;
 #endif
 
-    if (!kernel_filename && !qtest_enabled()) {
-        error_report("Guest image must be specified (using -kernel)");
-        exit(1);
-    }
-
     if (arm_feature(&cpu->env, ARM_FEATURE_EL3)) {
         asidx = ARMASIdx_S;
     } else {
-- 
2.20.1

             reply	other threads:[~2019-01-03 14:41 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-03 14:41 Stefan Hajnoczi [this message]
2019-01-04 15:16 ` [Qemu-devel] [PATCH] Revert "armv7m: Guard against no -kernel argument" Peter Maydell
2019-04-25 18:07   ` Philippe Mathieu-Daudé
2019-04-25 18:07     ` Philippe Mathieu-Daudé
2019-04-25 21:48     ` Philippe Mathieu-Daudé
2019-04-25 21:48       ` Philippe Mathieu-Daudé
2019-04-26  9:17     ` Stefan Hajnoczi
2019-04-26  9:17       ` Stefan Hajnoczi
2019-04-26 11:45       ` Peter Maydell
2019-04-26 11:45         ` Peter Maydell
2019-04-29 12:28         ` Stefan Hajnoczi
2019-04-29 12:28           ` Stefan Hajnoczi
2019-04-29 12:58           ` Peter Maydell
2019-04-29 12:58             ` Peter Maydell
2019-05-01 16:25             ` Stefan Hajnoczi
2019-05-01 16:25               ` Stefan Hajnoczi
2019-04-29 15:07           ` Philippe Mathieu-Daudé
2019-04-29 15:07             ` Philippe Mathieu-Daudé
2019-04-29 12:53       ` Joel Stanley
2019-04-29 12:53         ` Joel Stanley
2019-05-01 16:23         ` Stefan Hajnoczi
2019-05-01 16:23           ` Stefan Hajnoczi
2019-05-03  2:04           ` Joel Stanley
2019-05-03  2:04             ` Joel Stanley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190103144124.18917-1-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=jim@groklearning.com \
    --cc=joel@jms.id.au \
    --cc=jusual@mail.ru \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu.ml@steffen-goertz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).