From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50892) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gfM8O-0005IK-Bb for qemu-devel@nongnu.org; Fri, 04 Jan 2019 04:51:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gfM8L-0001yr-5t for qemu-devel@nongnu.org; Fri, 04 Jan 2019 04:51:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41850) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gfM8L-0001y4-08 for qemu-devel@nongnu.org; Fri, 04 Jan 2019 04:51:17 -0500 From: P J P Date: Fri, 4 Jan 2019 15:19:10 +0530 Message-Id: <20190104094910.5108-1-ppandit@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v1] sun4u: add power_mem_read routine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland Cc: QEMU Developers , Fakhri Zulkifli , Artyom Tarasenko , Prasad J Pandit From: Prasad J Pandit Define skeleton 'power_mem_read' routine. Avoid NULL dereference. Reported-by: Fakhri Zulkifli Signed-off-by: Prasad J Pandit --- hw/sparc64/sun4u.c | 6 ++++++ 1 file changed, 6 insertions(+) Update v1: change return value to zero(0) -> https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg00448.html diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c index f76b19e4e9..5772da02cb 100644 --- a/hw/sparc64/sun4u.c +++ b/hw/sparc64/sun4u.c @@ -214,6 +214,11 @@ typedef struct PowerDevice { } PowerDevice; =20 /* Power */ +static uint64_t power_mem_read(void *opaque, hwaddr addr, unsigned size) +{ + return 0; +} + static void power_mem_write(void *opaque, hwaddr addr, uint64_t val, unsigned size) { @@ -224,6 +229,7 @@ static void power_mem_write(void *opaque, hwaddr addr= , } =20 static const MemoryRegionOps power_mem_ops =3D { + .read =3D power_mem_read, .write =3D power_mem_write, .endianness =3D DEVICE_NATIVE_ENDIAN, .valid =3D { --=20 2.20.1