From: Cornelia Huck <cohuck@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
qemu-devel@nongnu.org, Thomas Huth <thuth@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] compat: Use explicit type names on HW_COMPAT_2_6
Date: Mon, 7 Jan 2019 09:12:06 +0100 [thread overview]
Message-ID: <20190107091206.6b5bd772.cohuck@redhat.com> (raw)
In-Reply-To: <20190104220050.GK4157@habkost.net>
On Fri, 4 Jan 2019 20:00:50 -0200
Eduardo Habkost <ehabkost@redhat.com> wrote:
> On Fri, Jan 04, 2019 at 04:13:15PM -0500, Michael S. Tsirkin wrote:
> > On Fri, Jan 04, 2019 at 07:06:56PM -0200, Eduardo Habkost wrote:
> > > On Fri, Jan 04, 2019 at 03:48:02PM -0500, Michael S. Tsirkin wrote:
> > > > On Fri, Jan 04, 2019 at 06:09:52PM -0200, Eduardo Habkost wrote:
> > > > > Anyway, while writing this I noticed another issue: many of the
> > > > > virtio devices in QEMU 2.6 were already modern-only!
> > > > >
> > > > > Setting disable-modern=off on modern-only devices like virtio-vga
> > > > > or virtio-tablet-pci doesn't make sense. This means setting
> > > > > virtio-pci.disable-modern=off on HW_COMPAT_2_6 was incorrect even
> > > > > before the -non-transitional and -transitional device types were
> > > > > introduced.
> > > >
> > > >
> > > > It did create an opportunity to create non working devices.
> > > >
> > > > Whether that's incorrect as such I'm not sure.
> > >
> > > This is not just creating the opportunity for an user to
> > > disable-modern=on. HW_COMPAT_2_6 is actually setting
> > > disable-modern=on on virtio-vga and other modern-only devices.
> > > Sounds like a mistake to me.
> > >
> > > Luckily those modern-only devices silently ignore the
> > > disable-modern/disable-legacy properties, but this might change
> > > in the future.
> >
> > Worry about it then?
>
> Right, we don't need to worry about it today. But if a solution
> to the crash reported by Thomas will make the problem go away,
> that's even better.
It seems your patch with the modern-only devices removed from the list
would achieve that?
next prev parent reply other threads:[~2019-01-07 8:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 3:22 [Qemu-devel] [PATCH] compat: Use explicit type names on HW_COMPAT_2_6 Eduardo Habkost
2019-01-04 4:23 ` Michael S. Tsirkin
2019-01-04 9:37 ` Cornelia Huck
2019-01-04 10:12 ` Dr. David Alan Gilbert
2019-01-04 17:54 ` Eduardo Habkost
2019-01-04 20:09 ` Eduardo Habkost
2019-01-04 20:48 ` Michael S. Tsirkin
2019-01-04 21:06 ` Eduardo Habkost
2019-01-04 21:13 ` Michael S. Tsirkin
2019-01-04 22:00 ` Eduardo Habkost
2019-01-07 8:12 ` Cornelia Huck [this message]
2019-01-07 19:26 ` Eduardo Habkost
2019-01-04 16:08 ` Eduardo Habkost
2019-01-04 9:49 ` Cornelia Huck
2019-01-04 16:11 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107091206.6b5bd772.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).