From: Olaf Hering <olaf@aepfle.de>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Ian Jackson <ian.jackson@citrix.com>,
qemu-devel@nongnu.org,
Stefano Stabellini <sstabellini@kernel.org>,
"open list:X86" <xen-devel@lists.xenproject.org>
Subject: Re: [Qemu-devel] [PATCH v1] xen: preserve COMPAT in CFLAGS
Date: Mon, 7 Jan 2019 15:20:16 +0100 [thread overview]
Message-ID: <20190107152016.03464ee3.olaf@aepfle.de> (raw)
In-Reply-To: <20181213110525.GY18875@perard.uk.xensource.com>
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
Am Thu, 13 Dec 2018 11:05:25 +0000
schrieb Anthony PERARD <anthony.perard@citrix.com>:
> Hi,
>
> Ian, we have those XC_WANT_COMPAT_* #defines to allow consumers of Xen
> libs be able to use old interfaces. Do you think it's a good idea to
> have this consumers (QEMU here) #undef the flag when it has implemented
> the newer interface?
I think the wording is wrong.
The defines exist to expose existing APIs to software that was not updated to use the "latest" API. To me it looks like the undef's are wrong. Even the usage in configure looks bogus, but that is another unrelated thing.
Olaf
[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2019-01-07 14:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 10:10 [Qemu-devel] [PATCH v1] xen: preserve COMPAT in CFLAGS Olaf Hering
2018-12-11 9:24 ` [Qemu-devel] [Xen-devel] " Olaf Hering
2018-12-13 11:05 ` [Qemu-devel] " Anthony PERARD
2019-01-07 14:20 ` Olaf Hering [this message]
2019-01-21 16:16 ` Anthony PERARD
2019-01-21 17:23 ` Anthony PERARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107152016.03464ee3.olaf@aepfle.de \
--to=olaf@aepfle.de \
--cc=anthony.perard@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).