* [Qemu-devel] [PATCH] spice: Remove unused include
@ 2019-01-07 18:44 Frediano Ziglio
2019-01-08 15:58 ` Philippe Mathieu-Daudé
2019-01-10 7:56 ` Gerd Hoffmann
0 siblings, 2 replies; 3+ messages in thread
From: Frediano Ziglio @ 2019-01-07 18:44 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel, spice-devel, Frediano Ziglio
The definitions in the header are not used.
Also this fixes porting SPICE to Windows where the header is not
available.
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
---
ui/spice-core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 525e0929b9..fb87944a24 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -18,7 +18,6 @@
#include "qemu/osdep.h"
#include <spice.h>
-#include <netdb.h>
#include "sysemu/sysemu.h"
#include "ui/qemu-spice.h"
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] spice: Remove unused include
2019-01-07 18:44 [Qemu-devel] [PATCH] spice: Remove unused include Frediano Ziglio
@ 2019-01-08 15:58 ` Philippe Mathieu-Daudé
2019-01-10 7:56 ` Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-01-08 15:58 UTC (permalink / raw)
To: Frediano Ziglio, Gerd Hoffmann; +Cc: spice-devel, qemu-devel
On 1/7/19 7:44 PM, Frediano Ziglio wrote:
> The definitions in the header are not used.
Indeed, since e16f4c8770b.
> Also this fixes porting SPICE to Windows where the header is not
> available.
>
> Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
(I might resend your patch in another series of mine)
> ---
> ui/spice-core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/ui/spice-core.c b/ui/spice-core.c
> index 525e0929b9..fb87944a24 100644
> --- a/ui/spice-core.c
> +++ b/ui/spice-core.c
> @@ -18,7 +18,6 @@
> #include "qemu/osdep.h"
> #include <spice.h>
>
> -#include <netdb.h>
> #include "sysemu/sysemu.h"
>
> #include "ui/qemu-spice.h"
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] spice: Remove unused include
2019-01-07 18:44 [Qemu-devel] [PATCH] spice: Remove unused include Frediano Ziglio
2019-01-08 15:58 ` Philippe Mathieu-Daudé
@ 2019-01-10 7:56 ` Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2019-01-10 7:56 UTC (permalink / raw)
To: Frediano Ziglio; +Cc: qemu-devel, spice-devel
On Mon, Jan 07, 2019 at 06:44:04PM +0000, Frediano Ziglio wrote:
> The definitions in the header are not used.
> Also this fixes porting SPICE to Windows where the header is not
> available.
Added to ui queue.
thanks,
Gerd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-10 7:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-07 18:44 [Qemu-devel] [PATCH] spice: Remove unused include Frediano Ziglio
2019-01-08 15:58 ` Philippe Mathieu-Daudé
2019-01-10 7:56 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).