From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:47526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggkXH-0007Z9-2f for qemu-devel@nongnu.org; Tue, 08 Jan 2019 01:06:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggkXG-0002XX-1c for qemu-devel@nongnu.org; Tue, 08 Jan 2019 01:06:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56846) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ggkXE-0002Qg-8V for qemu-devel@nongnu.org; Tue, 08 Jan 2019 01:06:45 -0500 Date: Tue, 8 Jan 2019 07:06:41 +0100 From: Gerd Hoffmann Message-ID: <20190108060641.2diwma66c33dymti@sirius.home.kraxel.org> References: <26b300d6c17e6ac015f1519d50151744cf806c03.1545598229.git.DirtY.iCE.hu@gmail.com> <87sgy4k3u7.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2 06/52] audio: -audiodev command line option basic implementation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?B?Wm9sdMOhbiBLxZF2w6Fnw7M=?= Cc: Markus Armbruster , qemu-devel@nongnu.org, Paolo Bonzini Hi, > > I suspect your series uses the options visitor only because back when > > you started, qobject_input_visitor_new_str() didn't exist. > > Yes, this patch series is a bit old, and at that time this was the best > I could do. I can look into it this (probably only on the weekend > though), it looks like it supports foo.bar=something syntax, so I don't > have to specify a json on the command line... It supports both, i.e. this ... qemu -display gtk,full-screen=on ... and this ... qemu -display '{ "type": "gtk", "full-screen": true }' ... has the same effect. cheers, Gerd