From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:35161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggoEp-0005Qw-3I for qemu-devel@nongnu.org; Tue, 08 Jan 2019 05:04:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggoEm-00052K-Si for qemu-devel@nongnu.org; Tue, 08 Jan 2019 05:03:58 -0500 Date: Tue, 8 Jan 2019 11:03:38 +0100 From: Cornelia Huck Message-ID: <20190108110338.60749ad6.cohuck@redhat.com> In-Reply-To: <20190107193020.21744-3-ehabkost@redhat.com> References: <20190107193020.21744-1-ehabkost@redhat.com> <20190107193020.21744-3-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] machine: Eliminate unnecessary stringify() usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, David Hildenbrand , Paolo Bonzini , Christian Borntraeger , =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , Richard Henderson , David Gibson , qemu-s390x@nongnu.org, Halil Pasic , Anthony Perard , Marcel Apfelbaum , Stefano Stabellini , "Michael S. Tsirkin" , qemu-ppc@nongnu.org, xen-devel@lists.xenproject.org On Mon, 7 Jan 2019 17:30:19 -0200 Eduardo Habkost wrote: > stringify() is useful when we need to use macros in compat_props > (like when we set virtio-baloon-pci.class=PCI_CLASS_MEMORY_RAM at > pc_i440fx_1_0_machine_options()), but it is pointless when we are > already providing a number literal. > > Replace stringify() with string literals when appropriate. > > Signed-off-by: Eduardo Habkost > --- > hw/core/machine.c | 8 ++-- > hw/i386/pc.c | 94 +++++++++++++++++++++++------------------------ > hw/i386/pc_piix.c | 30 +++++++-------- > hw/ppc/spapr.c | 2 +- > 4 files changed, 67 insertions(+), 67 deletions(-) Reviewed-by: Cornelia Huck