From: Kevin Wolf <kwolf@redhat.com>
To: Leonid Bloch <lbloch@janustech.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>,
"Stefan Weil" <sw@weilnetz.de>, "Max Reitz" <mreitz@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Alberto Garcia" <berto@igalia.com>,
"Markus Armbruster" <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table
Date: Tue, 8 Jan 2019 13:20:21 +0100 [thread overview]
Message-ID: <20190108122021.GB11492@linux.fritz.box> (raw)
In-Reply-To: <20190103213320.2653-2-lbloch@janustech.com>
Am 03.01.2019 um 22:33 hat Leonid Bloch geschrieben:
> The lookup table for power-of-two sizes is now auto-generated during the
> build, and not hard-coded into the units.h file.
>
> This partially reverts commit 540b8492618eb.
>
> Signed-off-by: Leonid Bloch <lbloch@janustech.com>
During a downstream review, Max found a problem with the table that we
could fix while we're touching it:
Upstream: All >= S_2GiB are not valid ints. (qemu assumes that
sizeof(int) == 4, right?) So S_2GiB should be 2147483648u and all
above should be ...ull or better UINT64_C().
Kevin
next prev parent reply other threads:[~2019-01-08 12:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 21:33 [Qemu-devel] [PATCH v2 0/1] include: Auto-generate the sizes lookup table Leonid Bloch
2019-01-03 21:33 ` [Qemu-devel] [PATCH v2 1/1] " Leonid Bloch
2019-01-08 9:31 ` Markus Armbruster
2019-01-08 15:19 ` Eric Blake
2019-01-10 9:42 ` Leonid Bloch
2019-01-10 12:40 ` Markus Armbruster
2019-01-10 16:49 ` Leonid Bloch
2019-01-10 19:11 ` Markus Armbruster
2019-01-10 13:33 ` Eric Blake
2019-01-10 19:33 ` Eric Blake
2019-01-08 12:20 ` Kevin Wolf [this message]
2019-01-10 10:04 ` Leonid Bloch
2019-01-10 12:51 ` Markus Armbruster
2019-01-10 16:53 ` Leonid Bloch
2019-01-11 7:50 ` Markus Armbruster
2019-01-11 15:29 ` Eric Blake
2019-01-10 12:51 ` Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190108122021.GB11492@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=lbloch@janustech.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).