From: Stefan Hajnoczi <stefanha@redhat.com>
To: kwolf@redhat.com
Cc: qemu-devel@nongnu.org, yuchenlin <npes87184@gmail.com>,
mreitz@redhat.com, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: add test case for dmg
Date: Tue, 8 Jan 2019 16:11:02 +0000 [thread overview]
Message-ID: <20190108161102.GH32358@stefanha-x1.localdomain> (raw)
In-Reply-To: <20190105084243.9524-1-npes87184@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1050 bytes --]
On Sat, Jan 05, 2019 at 04:42:43PM +0800, yuchenlin wrote:
> Recently, some bugs in dmg file have been fixed. To prevent reading dmg
> is broken someday in the future, add a simple test which ensures the
> conversion from dmg to raw should not hang or face any I/O error.
>
> Signed-off-by: yuchenlin <npes87184@gmail.com>
> ---
> tests/qemu-iotests/236 | 53 ++++++++++++++++++
> tests/qemu-iotests/236.out | 4 ++
> tests/qemu-iotests/check | 7 +++
> tests/qemu-iotests/group | 1 +
> .../sample_images/simple-dmg.dmg.bz2 | Bin 0 -> 3479 bytes
> 5 files changed, 65 insertions(+)
> create mode 100755 tests/qemu-iotests/236
> create mode 100644 tests/qemu-iotests/236.out
> create mode 100644 tests/qemu-iotests/sample_images/simple-dmg.dmg.bz2
Kevin: The prerequisite .dmg fixes are already in qemu.git/master.
Please review and take this through your tree, thanks!
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
prev parent reply other threads:[~2019-01-08 16:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-05 8:42 [Qemu-devel] [PATCH] qemu-iotests: add test case for dmg yuchenlin
2019-01-08 15:59 ` Kevin Wolf
2019-01-08 16:11 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190108161102.GH32358@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=npes87184@gmail.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).