* [Qemu-devel] [PATCH] block: Replace qdict_put() by qdict_put_obj() where appropriate
@ 2018-12-13 17:51 Markus Armbruster
2018-12-13 21:28 ` Eric Blake
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Markus Armbruster @ 2018-12-13 17:51 UTC (permalink / raw)
To: qemu-devel; +Cc: ari, kwolf, mreitz, qemu-block
Patch created mechanically by rerunning:
$ spatch --sp-file scripts/coccinelle/qobject.cocci \
--macro-file scripts/cocci-macro-file.h \
--dir block --in-place
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
block/blklogwrites.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/block/blklogwrites.c b/block/blklogwrites.c
index ff98cd5533..d2e01bdb1d 100644
--- a/block/blklogwrites.c
+++ b/block/blklogwrites.c
@@ -295,10 +295,9 @@ static void blk_log_writes_refresh_filename(BlockDriverState *bs,
qdict_put_str(opts, "driver", "blklogwrites");
qobject_ref(bs->file->bs->full_open_options);
- qdict_put_obj(opts, "file", QOBJECT(bs->file->bs->full_open_options));
+ qdict_put(opts, "file", bs->file->bs->full_open_options);
qobject_ref(s->log_file->bs->full_open_options);
- qdict_put_obj(opts, "log",
- QOBJECT(s->log_file->bs->full_open_options));
+ qdict_put(opts, "log", s->log_file->bs->full_open_options);
qdict_put_int(opts, "log-sector-size", s->sectorsize);
bs->full_open_options = opts;
--
2.17.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] block: Replace qdict_put() by qdict_put_obj() where appropriate
2018-12-13 17:51 [Qemu-devel] [PATCH] block: Replace qdict_put() by qdict_put_obj() where appropriate Markus Armbruster
@ 2018-12-13 21:28 ` Eric Blake
2018-12-14 8:13 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2019-01-08 19:06 ` [Qemu-devel] " Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Eric Blake @ 2018-12-13 21:28 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: kwolf, qemu-block, ari, mreitz
On 12/13/18 11:51 AM, Markus Armbruster wrote:
> Patch created mechanically by rerunning:
>
> $ spatch --sp-file scripts/coccinelle/qobject.cocci \
> --macro-file scripts/cocci-macro-file.h \
> --dir block --in-place
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> block/blklogwrites.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] block: Replace qdict_put() by qdict_put_obj() where appropriate
2018-12-13 17:51 [Qemu-devel] [PATCH] block: Replace qdict_put() by qdict_put_obj() where appropriate Markus Armbruster
2018-12-13 21:28 ` Eric Blake
@ 2018-12-14 8:13 ` Alberto Garcia
2019-01-08 19:06 ` [Qemu-devel] " Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Alberto Garcia @ 2018-12-14 8:13 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: kwolf, qemu-block, mreitz
On Thu 13 Dec 2018 06:51:54 PM CET, Markus Armbruster wrote:
> Patch created mechanically by rerunning:
>
> $ spatch --sp-file scripts/coccinelle/qobject.cocci \
> --macro-file scripts/cocci-macro-file.h \
> --dir block --in-place
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Berto
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] block: Replace qdict_put() by qdict_put_obj() where appropriate
2018-12-13 17:51 [Qemu-devel] [PATCH] block: Replace qdict_put() by qdict_put_obj() where appropriate Markus Armbruster
2018-12-13 21:28 ` Eric Blake
2018-12-14 8:13 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
@ 2019-01-08 19:06 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Kevin Wolf @ 2019-01-08 19:06 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel, ari, mreitz, qemu-block
Am 13.12.2018 um 18:51 hat Markus Armbruster geschrieben:
> Patch created mechanically by rerunning:
>
> $ spatch --sp-file scripts/coccinelle/qobject.cocci \
> --macro-file scripts/cocci-macro-file.h \
> --dir block --in-place
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-08 19:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-13 17:51 [Qemu-devel] [PATCH] block: Replace qdict_put() by qdict_put_obj() where appropriate Markus Armbruster
2018-12-13 21:28 ` Eric Blake
2018-12-14 8:13 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2019-01-08 19:06 ` [Qemu-devel] " Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).