qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: jsnow@redhat.com, qemu-block@nongnu.org, vsementsov@virtuozzo.com
Subject: [Qemu-devel] [PATCH 0/5] Promote x-nbd-server-add-bitmap to stable
Date: Tue,  8 Jan 2019 22:14:47 -0600	[thread overview]
Message-ID: <20190109041452.31240-1-eblake@redhat.com> (raw)

Or rather, move its functionality into nbd-server-add.  And as
a side effect, teach qemu-nbd how to export a persistent bitmap
without having to go through a qemu process and several QMP
commands.

Based-on: <20181221093529.23855-1-jsnow@redhat.com>
[0/11 bitmaps: remove x- prefix from QMP api]

Patch 5 was very lightly tested; I hope to have more time to play
with that patch alongside Andrey's pending [qemu-img info lists
bitmap directory entries], with an update to iotests to
demonstrate how it is possible to inspect dirty bitmaps by using
qemu-img to learn what is available then qemu-nbd to expose them.
It's still painful that there are no qemu-img commands for
creating a new persistent bitmap; that still has to be done via
QMP on a live guest.

Eric Blake (5):
  nbd: Merge nbd_export_set_name into nbd_export_new
  nbd: Allow bitmap export during QMP nbd-server-add
  nbd: Remove x-nbd-server-add-bitmap
  nbd: Merge nbd_export_bitmap into nbd_export_new
  qemu-nbd: Add --bitmap=NAME option

 qemu-nbd.texi              |   5 ++
 qapi/block.json            |  35 ++++-------
 include/block/nbd.h        |   7 +--
 blockdev-nbd.c             |  44 ++++++--------
 hmp.c                      |   6 +-
 nbd/server.c               | 121 ++++++++++++++++---------------------
 qemu-nbd.c                 |  19 ++++--
 tests/qemu-iotests/223     |  11 ++--
 tests/qemu-iotests/223.out |   2 -
 9 files changed, 109 insertions(+), 141 deletions(-)

-- 
2.20.1

             reply	other threads:[~2019-01-09  4:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-09  4:14 Eric Blake [this message]
2019-01-09  4:14 ` [Qemu-devel] [PATCH 1/5] nbd: Merge nbd_export_set_name into nbd_export_new Eric Blake
2019-01-09  4:14 ` [Qemu-devel] [PATCH 2/5] nbd: Allow bitmap export during QMP nbd-server-add Eric Blake
2019-01-10  3:34   ` Eric Blake
2019-01-09  4:14 ` [Qemu-devel] [PATCH 3/5] nbd: Remove x-nbd-server-add-bitmap Eric Blake
2019-01-09  4:14 ` [Qemu-devel] [PATCH 4/5] nbd: Merge nbd_export_bitmap into nbd_export_new Eric Blake
2019-01-09  4:14 ` [Qemu-devel] [PATCH 5/5] qemu-nbd: Add --bitmap=NAME option Eric Blake
2019-01-09 18:27   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190109041452.31240-1-eblake@redhat.com \
    --to=eblake@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).