qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kashyap Chamarthy <kchamart@redhat.com>
To: qemu-devel@nongnu.org
Cc: berrange@redhat.com, armbru@redhat.com, eblake@redhat.com
Subject: [Qemu-devel] Should the "props" be documented for QMP `object-add`?
Date: Wed, 9 Jan 2019 09:51:13 +0100	[thread overview]
Message-ID: <20190109085113.GA23677@paraplu> (raw)

I notice that the following QMP command:

    {
      "execute":"object-add",
      "arguments":{
        "qom-type":"tls-creds-x509",
        "id":"objlibvirt_migrate_tls0",
        "props":{
          "dir":"/etc/pki/qemu",
          "endpoint":"server",
          "verify-peer":true
        }
      }
    }

... is the same as its command-line equivalent:

    -object tls-creds-x509,id=tls0,dir=/etc/pki/qemu,endpoint=server,verify-peer=yes

That said, in qapi/misc.json "@object-add" doesn't document any of the
"props".  Is it on purpose?  Maybe because it is a 1:1 mapping of the
command-line `-object` (which _is_ documented in qemu-doc.texi).

Is it a good idea to send a patch to document the "props" in
qapi/misc.json?  Or would it be needless duplication?

-- 
/kashyap

             reply	other threads:[~2019-01-09  8:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-09  8:51 Kashyap Chamarthy [this message]
2019-01-09 10:31 ` [Qemu-devel] Should the "props" be documented for QMP `object-add`? Philippe Mathieu-Daudé
2019-01-09 10:44   ` Kashyap Chamarthy
2019-01-09 11:02 ` Daniel P. Berrangé
2019-01-09 11:21   ` Kashyap Chamarthy
2019-01-09 13:01   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190109085113.GA23677@paraplu \
    --to=kchamart@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).