From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:45638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ghF9i-0002wD-OX for qemu-devel@nongnu.org; Wed, 09 Jan 2019 09:48:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ghF9e-0006JL-RH for qemu-devel@nongnu.org; Wed, 09 Jan 2019 09:48:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:17624) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ghF9Z-0006Ca-Se for qemu-devel@nongnu.org; Wed, 09 Jan 2019 09:48:23 -0500 Date: Wed, 9 Jan 2019 09:48:08 -0500 From: "Michael S. Tsirkin" Message-ID: <20190109094732-mutt-send-email-mst@kernel.org> References: <20190109082902.32271-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20190109082902.32271-1-marcandre.lureau@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v15 0/6] Add support for TPM Physical Presence interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau Cc: qemu-devel@nongnu.org, Paolo Bonzini , stefanb@linux.vnet.ibm.com, Marcel Apfelbaum , f4bug@amsat.org, Eduardo Habkost , Stefan Berger , Igor Mammedov , Richard Henderson On Wed, Jan 09, 2019 at 12:28:56PM +0400, Marc-Andr=E9 Lureau wrote: > Hi, >=20 > The following patches implement the TPM Physical Presence Interface > that allows a user to set a command via ACPI (sysfs entry in Linux) > that, upon the next reboot, the firmware looks for and acts upon by > sending sequences of commands to the TPM. >=20 > A dedicated memory region is added to the TPM CRB & TIS devices, at > address/size 0xFED45000/0x400. A new "etc/tpm/config" fw_cfg entry > holds the location for that PPI region and some version details, to > allow for future flexibility. >=20 > With the associated edk2/ovmf firmware, the Windows HLK "PPI 1.3" test > now runs successfully. >=20 > It is based on previous work from Stefan Berger ("[PATCH v2 0/4] > Implement Physical Presence interface for TPM 1.2 and 2") >=20 > The edk2 support is merged upstream. So it looks good to me overall. Minor style comments. With or without: Reviewed-by: Michael S. Tsirkin > v15: > - fix crash on reset when PPI is disabled >=20 > v14: > - rebased, fixing conflicts after compat-props refactoring > - fix build regression from v13 with --disable-tpm >=20 > v13: > - removed needless error handling in tpm_ppi_init() > - splitted "add ACPI memory clear interface" > - moved acpi build function in dedicated hw/acpi/tpm.c > - added some function documentation in headers > - various code cleanups suggested by Philippe > - rebased >=20 > Marc-Andr=E9 Lureau (3): > tpm: add a "ppi" boolean property > acpi: add ACPI memory clear interface > tpm: clear RAM when "memory overwrite" requested >=20 > Stefan Berger (3): > tpm: allocate/map buffer for TPM Physical Presence interface > acpi: expose TPM/PPI configuration parameters to firmware via fw_cfg > acpi: build TPM Physical Presence interface >=20 > hw/tpm/tpm_ppi.h | 46 +++++ > include/hw/acpi/tpm.h | 21 ++ > hw/acpi/tpm.c | 448 ++++++++++++++++++++++++++++++++++++++++++ > hw/core/machine.c | 8 + > hw/i386/acpi-build.c | 29 ++- > hw/tpm/tpm_crb.c | 13 ++ > hw/tpm/tpm_ppi.c | 53 +++++ > hw/tpm/tpm_tis.c | 13 ++ > stubs/tpm.c | 5 + > docs/specs/tpm.txt | 104 ++++++++++ > hw/acpi/Makefile.objs | 1 + > hw/tpm/Makefile.objs | 1 + > hw/tpm/trace-events | 3 + > 13 files changed, 743 insertions(+), 2 deletions(-) > create mode 100644 hw/tpm/tpm_ppi.h > create mode 100644 hw/acpi/tpm.c > create mode 100644 hw/tpm/tpm_ppi.c >=20 > --=20 > 2.20.1.2.gb21ebb671b