* Re: [Qemu-devel] [PATCH 2/2] MAINTAINERS: Remove myself as block maintainer
[not found] ` <87va6uvxhv.fsf@dusky.pond.sub.org>
@ 2019-01-08 17:18 ` Markus Armbruster
2019-01-08 19:12 ` Kevin Wolf
0 siblings, 1 reply; 6+ messages in thread
From: Markus Armbruster @ 2019-01-08 17:18 UTC (permalink / raw)
To: qemu-block; +Cc: Fam Zheng, kwolf, Jeff Cody, qemu-devel, mreitz, jsnow
This patch series got stuck.
Markus Armbruster <armbru@redhat.com> writes:
> Fam Zheng <famz@redhat.com> writes:
>
>> On Tue, 09/25 07:00, Markus Armbruster wrote:
>>> Jeff Cody <jcody@redhat.com> writes:
>>>
>>> > I'll not be involved in day-to-day qemu development. Remove
>>> > myself as maintainer from the remainder of the network block drivers
>>> > (and vhdx), and revert them to the general block layer maintainership.
>>> >
>>> > Signed-off-by: Jeff Cody <jcody@redhat.com>
>>> > ---
>>> > MAINTAINERS | 14 --------------
>>> > 1 file changed, 14 deletions(-)
>>> >
>>> > diff --git a/MAINTAINERS b/MAINTAINERS
>>> > index e93f79672f..6ef6932628 100644
>>> > --- a/MAINTAINERS
>>> > +++ b/MAINTAINERS
>>> > @@ -1982,28 +1982,22 @@ F: block/vmdk.c
>>> >
>>> > RBD
>>> > M: Josh Durgin <jdurgin@redhat.com>
>>> > -M: Jeff Cody <jcody@redhat.com>
>>> > L: qemu-block@nongnu.org
>>> > S: Supported
>>> > F: block/rbd.c
>>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>> >
>>> > Sheepdog
>>> > M: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
>>> > M: Liu Yuan <namei.unix@gmail.com>
>>> > -M: Jeff Cody <jcody@redhat.com>
>>> > L: qemu-block@nongnu.org
>>> > L: sheepdog@lists.wpkg.org
>>> > S: Supported
>>> > F: block/sheepdog.c
>>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>> >
>>> > VHDX
>>> > -M: Jeff Cody <jcody@redhat.com>
>>> > L: qemu-block@nongnu.org
>>> > S: Supported
>>> > F: block/vhdx*
>>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>
>>> Does "S: Supported" make sense without an M:?
>>>
>>> >
>>> > VDI
>>> > M: Stefan Weil <sw@weilnetz.de>
>>> > @@ -2034,34 +2028,26 @@ F: docs/interop/nbd.txt
>>> > T: git git://repo.or.cz/qemu/ericb.git nbd
>>> >
>>> > NFS
>>> > -M: Jeff Cody <jcody@redhat.com>
>>> > M: Peter Lieven <pl@kamp.de>
>>> > L: qemu-block@nongnu.org
>>> > S: Maintained
>>> > F: block/nfs.c
>>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>> >
>>> > SSH
>>> > M: Richard W.M. Jones <rjones@redhat.com>
>>> > -M: Jeff Cody <jcody@redhat.com>
>>> > L: qemu-block@nongnu.org
>>> > S: Supported
>>> > F: block/ssh.c
>>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>> >
>>> > CURL
>>> > -M: Jeff Cody <jcody@redhat.com>
>>> > L: qemu-block@nongnu.org
>>> > S: Supported
>>> > F: block/curl.c
>>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>
>>> Likewise.
>>>
>>> > GLUSTER
>>> > -M: Jeff Cody <jcody@redhat.com>
>>> > L: qemu-block@nongnu.org
>>> > S: Supported
>>> > F: block/gluster.c
>>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>
>>> Likewise.
>>>
>>> > Null Block Driver
>>> > M: Fam Zheng <famz@redhat.com>
>>>
>>
>> Block drivers without an M: naturally fall under the overall maintainership of
>> block layer (Kevin&Max), so IMO keeping the statuses is fine. Maybe CURL can be
>> degraded to Maintained, though.
>
> Yes, get_maintainer.pl combines all applicable sections. Human readers
> are left to wonder, unless they know to look for other matches.
>
> Do we want to have a dedicated network block driver submaintainer again,
> if we can find one?
>
> Do we want to have a dedicated VHDX driver submaintainer again? Fam,
> you're maintaining VMDK, could you cover VHDX as well?
Fam can't.
I can see two sane options for the three sections that lose their sole
maintainer (VHDX, CURL, GLUSTER):
* Downgrade to S: Orphan
This reflects the fact that we'd like to have dedicated maintainers
for them. It camouflages the fact that the "Block layer core"
maintainers pick up the slack.
* Delete
The opposite.
Kevin, Max, please pick your poison, or suggest one you find tastier.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] MAINTAINERS: Remove myself as block maintainer
2019-01-08 17:18 ` [Qemu-devel] [PATCH 2/2] MAINTAINERS: Remove myself as block maintainer Markus Armbruster
@ 2019-01-08 19:12 ` Kevin Wolf
2019-01-09 10:15 ` Thomas Huth
2019-01-09 11:43 ` [Qemu-devel] [Qemu-block] " Niels de Vos
0 siblings, 2 replies; 6+ messages in thread
From: Kevin Wolf @ 2019-01-08 19:12 UTC (permalink / raw)
To: Markus Armbruster
Cc: qemu-block, Fam Zheng, Jeff Cody, qemu-devel, mreitz, jsnow
Am 08.01.2019 um 18:18 hat Markus Armbruster geschrieben:
> This patch series got stuck.
>
> Markus Armbruster <armbru@redhat.com> writes:
>
> > Fam Zheng <famz@redhat.com> writes:
> >
> >> On Tue, 09/25 07:00, Markus Armbruster wrote:
> >>> Jeff Cody <jcody@redhat.com> writes:
> >>>
> >>> > I'll not be involved in day-to-day qemu development. Remove
> >>> > myself as maintainer from the remainder of the network block drivers
> >>> > (and vhdx), and revert them to the general block layer maintainership.
> >>> >
> >>> > Signed-off-by: Jeff Cody <jcody@redhat.com>
> >>> > ---
> >>> > MAINTAINERS | 14 --------------
> >>> > 1 file changed, 14 deletions(-)
> >>> >
> >>> > diff --git a/MAINTAINERS b/MAINTAINERS
> >>> > index e93f79672f..6ef6932628 100644
> >>> > --- a/MAINTAINERS
> >>> > +++ b/MAINTAINERS
> >>> > @@ -1982,28 +1982,22 @@ F: block/vmdk.c
> >>> >
> >>> > RBD
> >>> > M: Josh Durgin <jdurgin@redhat.com>
> >>> > -M: Jeff Cody <jcody@redhat.com>
> >>> > L: qemu-block@nongnu.org
> >>> > S: Supported
> >>> > F: block/rbd.c
> >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> >>> >
> >>> > Sheepdog
> >>> > M: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
> >>> > M: Liu Yuan <namei.unix@gmail.com>
> >>> > -M: Jeff Cody <jcody@redhat.com>
> >>> > L: qemu-block@nongnu.org
> >>> > L: sheepdog@lists.wpkg.org
> >>> > S: Supported
> >>> > F: block/sheepdog.c
> >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> >>> >
> >>> > VHDX
> >>> > -M: Jeff Cody <jcody@redhat.com>
> >>> > L: qemu-block@nongnu.org
> >>> > S: Supported
> >>> > F: block/vhdx*
> >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> >>>
> >>> Does "S: Supported" make sense without an M:?
> >>>
> >>> >
> >>> > VDI
> >>> > M: Stefan Weil <sw@weilnetz.de>
> >>> > @@ -2034,34 +2028,26 @@ F: docs/interop/nbd.txt
> >>> > T: git git://repo.or.cz/qemu/ericb.git nbd
> >>> >
> >>> > NFS
> >>> > -M: Jeff Cody <jcody@redhat.com>
> >>> > M: Peter Lieven <pl@kamp.de>
> >>> > L: qemu-block@nongnu.org
> >>> > S: Maintained
> >>> > F: block/nfs.c
> >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> >>> >
> >>> > SSH
> >>> > M: Richard W.M. Jones <rjones@redhat.com>
> >>> > -M: Jeff Cody <jcody@redhat.com>
> >>> > L: qemu-block@nongnu.org
> >>> > S: Supported
> >>> > F: block/ssh.c
> >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> >>> >
> >>> > CURL
> >>> > -M: Jeff Cody <jcody@redhat.com>
> >>> > L: qemu-block@nongnu.org
> >>> > S: Supported
> >>> > F: block/curl.c
> >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> >>>
> >>> Likewise.
> >>>
> >>> > GLUSTER
> >>> > -M: Jeff Cody <jcody@redhat.com>
> >>> > L: qemu-block@nongnu.org
> >>> > S: Supported
> >>> > F: block/gluster.c
> >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> >>>
> >>> Likewise.
> >>>
> >>> > Null Block Driver
> >>> > M: Fam Zheng <famz@redhat.com>
> >>>
> >>
> >> Block drivers without an M: naturally fall under the overall maintainership of
> >> block layer (Kevin&Max), so IMO keeping the statuses is fine. Maybe CURL can be
> >> degraded to Maintained, though.
> >
> > Yes, get_maintainer.pl combines all applicable sections. Human readers
> > are left to wonder, unless they know to look for other matches.
> >
> > Do we want to have a dedicated network block driver submaintainer again,
> > if we can find one?
> >
> > Do we want to have a dedicated VHDX driver submaintainer again? Fam,
> > you're maintaining VMDK, could you cover VHDX as well?
>
> Fam can't.
>
> I can see two sane options for the three sections that lose their sole
> maintainer (VHDX, CURL, GLUSTER):
>
> * Downgrade to S: Orphan
>
> This reflects the fact that we'd like to have dedicated maintainers
> for them. It camouflages the fact that the "Block layer core"
> maintainers pick up the slack.
>
> * Delete
>
> The opposite.
>
> Kevin, Max, please pick your poison, or suggest one you find tastier.
Orphan is probably by far closer to the truth than Supported. But I
think what we really do is Odd Fixes. Not sure if that's a status that
works in any meaningful way without having a maintainer for the specific
thing assigned?
Kevin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] MAINTAINERS: Remove myself as block maintainer
2019-01-08 19:12 ` Kevin Wolf
@ 2019-01-09 10:15 ` Thomas Huth
2019-01-09 12:39 ` Markus Armbruster
2019-01-09 11:43 ` [Qemu-devel] [Qemu-block] " Niels de Vos
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Huth @ 2019-01-09 10:15 UTC (permalink / raw)
To: Kevin Wolf, Markus Armbruster
Cc: Fam Zheng, qemu-block, qemu-devel, mreitz, Jeff Cody, jsnow
On 2019-01-08 20:12, Kevin Wolf wrote:
> Am 08.01.2019 um 18:18 hat Markus Armbruster geschrieben:
>> This patch series got stuck.
>>
>> Markus Armbruster <armbru@redhat.com> writes:
>>
>>> Fam Zheng <famz@redhat.com> writes:
>>>
>>>> On Tue, 09/25 07:00, Markus Armbruster wrote:
>>>>> Jeff Cody <jcody@redhat.com> writes:
>>>>>
>>>>>> I'll not be involved in day-to-day qemu development. Remove
>>>>>> myself as maintainer from the remainder of the network block drivers
>>>>>> (and vhdx), and revert them to the general block layer maintainership.
>>>>>>
>>>>>> Signed-off-by: Jeff Cody <jcody@redhat.com>
>>>>>> ---
>>>>>> MAINTAINERS | 14 --------------
>>>>>> 1 file changed, 14 deletions(-)
>>>>>>
>>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>>>> index e93f79672f..6ef6932628 100644
>>>>>> --- a/MAINTAINERS
>>>>>> +++ b/MAINTAINERS
>>>>>> @@ -1982,28 +1982,22 @@ F: block/vmdk.c
>>>>>>
>>>>>> RBD
>>>>>> M: Josh Durgin <jdurgin@redhat.com>
>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>> L: qemu-block@nongnu.org
>>>>>> S: Supported
>>>>>> F: block/rbd.c
>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>
>>>>>> Sheepdog
>>>>>> M: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
>>>>>> M: Liu Yuan <namei.unix@gmail.com>
>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>> L: qemu-block@nongnu.org
>>>>>> L: sheepdog@lists.wpkg.org
>>>>>> S: Supported
>>>>>> F: block/sheepdog.c
>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>
>>>>>> VHDX
>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>> L: qemu-block@nongnu.org
>>>>>> S: Supported
>>>>>> F: block/vhdx*
>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>
>>>>> Does "S: Supported" make sense without an M:?
>>>>>
>>>>>>
>>>>>> VDI
>>>>>> M: Stefan Weil <sw@weilnetz.de>
>>>>>> @@ -2034,34 +2028,26 @@ F: docs/interop/nbd.txt
>>>>>> T: git git://repo.or.cz/qemu/ericb.git nbd
>>>>>>
>>>>>> NFS
>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>> M: Peter Lieven <pl@kamp.de>
>>>>>> L: qemu-block@nongnu.org
>>>>>> S: Maintained
>>>>>> F: block/nfs.c
>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>
>>>>>> SSH
>>>>>> M: Richard W.M. Jones <rjones@redhat.com>
>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>> L: qemu-block@nongnu.org
>>>>>> S: Supported
>>>>>> F: block/ssh.c
>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>
>>>>>> CURL
>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>> L: qemu-block@nongnu.org
>>>>>> S: Supported
>>>>>> F: block/curl.c
>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>
>>>>> Likewise.
>>>>>
>>>>>> GLUSTER
>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>> L: qemu-block@nongnu.org
>>>>>> S: Supported
>>>>>> F: block/gluster.c
>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>
>>>>> Likewise.
>>>>>
>>>>>> Null Block Driver
>>>>>> M: Fam Zheng <famz@redhat.com>
>>>>>
>>>>
>>>> Block drivers without an M: naturally fall under the overall maintainership of
>>>> block layer (Kevin&Max), so IMO keeping the statuses is fine. Maybe CURL can be
>>>> degraded to Maintained, though.
>>>
>>> Yes, get_maintainer.pl combines all applicable sections. Human readers
>>> are left to wonder, unless they know to look for other matches.
>>>
>>> Do we want to have a dedicated network block driver submaintainer again,
>>> if we can find one?
>>>
>>> Do we want to have a dedicated VHDX driver submaintainer again? Fam,
>>> you're maintaining VMDK, could you cover VHDX as well?
>>
>> Fam can't.
>>
>> I can see two sane options for the three sections that lose their sole
>> maintainer (VHDX, CURL, GLUSTER):
>>
>> * Downgrade to S: Orphan
>>
>> This reflects the fact that we'd like to have dedicated maintainers
>> for them. It camouflages the fact that the "Block layer core"
>> maintainers pick up the slack.
>>
>> * Delete
>>
>> The opposite.
>>
>> Kevin, Max, please pick your poison, or suggest one you find tastier.
>
> Orphan is probably by far closer to the truth than Supported. But I
> think what we really do is Odd Fixes. Not sure if that's a status that
> works in any meaningful way without having a maintainer for the specific
> thing assigned?
IMHO "Odd Fixes" is still ok for entries that have at least a "L:" line,
like "L: qemu-block@nongnu.org". If an entry neither got a "M:" nor a
"L:" line anymore, it should be marked with "Orphan" instead.
Thomas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] MAINTAINERS: Remove myself as block maintainer
2019-01-08 19:12 ` Kevin Wolf
2019-01-09 10:15 ` Thomas Huth
@ 2019-01-09 11:43 ` Niels de Vos
2019-01-09 12:46 ` Markus Armbruster
1 sibling, 1 reply; 6+ messages in thread
From: Niels de Vos @ 2019-01-09 11:43 UTC (permalink / raw)
To: Kevin Wolf
Cc: Markus Armbruster, Fam Zheng, qemu-block, qemu-devel, mreitz,
Jeff Cody
On Tue, Jan 08, 2019 at 08:12:16PM +0100, Kevin Wolf wrote:
> Am 08.01.2019 um 18:18 hat Markus Armbruster geschrieben:
> > This patch series got stuck.
> >
> > Markus Armbruster <armbru@redhat.com> writes:
> >
> > > Fam Zheng <famz@redhat.com> writes:
> > >
> > >> On Tue, 09/25 07:00, Markus Armbruster wrote:
> > >>> Jeff Cody <jcody@redhat.com> writes:
> > >>>
> > >>> > I'll not be involved in day-to-day qemu development. Remove
> > >>> > myself as maintainer from the remainder of the network block drivers
> > >>> > (and vhdx), and revert them to the general block layer maintainership.
> > >>> >
> > >>> > Signed-off-by: Jeff Cody <jcody@redhat.com>
> > >>> > ---
> > >>> > MAINTAINERS | 14 --------------
> > >>> > 1 file changed, 14 deletions(-)
> > >>> >
> > >>> > diff --git a/MAINTAINERS b/MAINTAINERS
> > >>> > index e93f79672f..6ef6932628 100644
> > >>> > --- a/MAINTAINERS
> > >>> > +++ b/MAINTAINERS
> > >>> > @@ -1982,28 +1982,22 @@ F: block/vmdk.c
> > >>> >
> > >>> > RBD
> > >>> > M: Josh Durgin <jdurgin@redhat.com>
> > >>> > -M: Jeff Cody <jcody@redhat.com>
> > >>> > L: qemu-block@nongnu.org
> > >>> > S: Supported
> > >>> > F: block/rbd.c
> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> > >>> >
> > >>> > Sheepdog
> > >>> > M: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
> > >>> > M: Liu Yuan <namei.unix@gmail.com>
> > >>> > -M: Jeff Cody <jcody@redhat.com>
> > >>> > L: qemu-block@nongnu.org
> > >>> > L: sheepdog@lists.wpkg.org
> > >>> > S: Supported
> > >>> > F: block/sheepdog.c
> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> > >>> >
> > >>> > VHDX
> > >>> > -M: Jeff Cody <jcody@redhat.com>
> > >>> > L: qemu-block@nongnu.org
> > >>> > S: Supported
> > >>> > F: block/vhdx*
> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> > >>>
> > >>> Does "S: Supported" make sense without an M:?
> > >>>
> > >>> >
> > >>> > VDI
> > >>> > M: Stefan Weil <sw@weilnetz.de>
> > >>> > @@ -2034,34 +2028,26 @@ F: docs/interop/nbd.txt
> > >>> > T: git git://repo.or.cz/qemu/ericb.git nbd
> > >>> >
> > >>> > NFS
> > >>> > -M: Jeff Cody <jcody@redhat.com>
> > >>> > M: Peter Lieven <pl@kamp.de>
> > >>> > L: qemu-block@nongnu.org
> > >>> > S: Maintained
> > >>> > F: block/nfs.c
> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> > >>> >
> > >>> > SSH
> > >>> > M: Richard W.M. Jones <rjones@redhat.com>
> > >>> > -M: Jeff Cody <jcody@redhat.com>
> > >>> > L: qemu-block@nongnu.org
> > >>> > S: Supported
> > >>> > F: block/ssh.c
> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> > >>> >
> > >>> > CURL
> > >>> > -M: Jeff Cody <jcody@redhat.com>
> > >>> > L: qemu-block@nongnu.org
> > >>> > S: Supported
> > >>> > F: block/curl.c
> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> > >>>
> > >>> Likewise.
> > >>>
> > >>> > GLUSTER
> > >>> > -M: Jeff Cody <jcody@redhat.com>
> > >>> > L: qemu-block@nongnu.org
> > >>> > S: Supported
> > >>> > F: block/gluster.c
> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
> > >>>
> > >>> Likewise.
> > >>>
> > >>> > Null Block Driver
> > >>> > M: Fam Zheng <famz@redhat.com>
> > >>>
> > >>
> > >> Block drivers without an M: naturally fall under the overall maintainership of
> > >> block layer (Kevin&Max), so IMO keeping the statuses is fine. Maybe CURL can be
> > >> degraded to Maintained, though.
> > >
> > > Yes, get_maintainer.pl combines all applicable sections. Human readers
> > > are left to wonder, unless they know to look for other matches.
> > >
> > > Do we want to have a dedicated network block driver submaintainer again,
> > > if we can find one?
> > >
> > > Do we want to have a dedicated VHDX driver submaintainer again? Fam,
> > > you're maintaining VMDK, could you cover VHDX as well?
> >
> > Fam can't.
> >
> > I can see two sane options for the three sections that lose their sole
> > maintainer (VHDX, CURL, GLUSTER):
> >
> > * Downgrade to S: Orphan
> >
> > This reflects the fact that we'd like to have dedicated maintainers
> > for them. It camouflages the fact that the "Block layer core"
> > maintainers pick up the slack.
> >
> > * Delete
> >
> > The opposite.
> >
> > Kevin, Max, please pick your poison, or suggest one you find tastier.
>
> Orphan is probably by far closer to the truth than Supported. But I
> think what we really do is Odd Fixes. Not sure if that's a status that
> works in any meaningful way without having a maintainer for the specific
> thing assigned?
For Gluster we are interested in keeping it maintained in some form. At
least integration@gluster.org could be added as a list. I am not sure
there is anyone working on Gluster that would fit for a maintainer of
the driver. If you really want to put a name there, I can function as a
'maintainer' and pull in other Gluster developers in case I am otherwise
occupied.
Niels
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] MAINTAINERS: Remove myself as block maintainer
2019-01-09 10:15 ` Thomas Huth
@ 2019-01-09 12:39 ` Markus Armbruster
0 siblings, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2019-01-09 12:39 UTC (permalink / raw)
To: Thomas Huth
Cc: Kevin Wolf, Fam Zheng, qemu-block, qemu-devel, mreitz, Jeff Cody,
jsnow
Thomas Huth <thuth@redhat.com> writes:
> On 2019-01-08 20:12, Kevin Wolf wrote:
>> Am 08.01.2019 um 18:18 hat Markus Armbruster geschrieben:
>>> This patch series got stuck.
>>>
>>> Markus Armbruster <armbru@redhat.com> writes:
>>>
>>>> Fam Zheng <famz@redhat.com> writes:
>>>>
>>>>> On Tue, 09/25 07:00, Markus Armbruster wrote:
>>>>>> Jeff Cody <jcody@redhat.com> writes:
>>>>>>
>>>>>>> I'll not be involved in day-to-day qemu development. Remove
>>>>>>> myself as maintainer from the remainder of the network block drivers
>>>>>>> (and vhdx), and revert them to the general block layer maintainership.
>>>>>>>
>>>>>>> Signed-off-by: Jeff Cody <jcody@redhat.com>
>>>>>>> ---
>>>>>>> MAINTAINERS | 14 --------------
>>>>>>> 1 file changed, 14 deletions(-)
>>>>>>>
>>>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>>>>> index e93f79672f..6ef6932628 100644
>>>>>>> --- a/MAINTAINERS
>>>>>>> +++ b/MAINTAINERS
>>>>>>> @@ -1982,28 +1982,22 @@ F: block/vmdk.c
>>>>>>>
>>>>>>> RBD
>>>>>>> M: Josh Durgin <jdurgin@redhat.com>
>>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>> L: qemu-block@nongnu.org
>>>>>>> S: Supported
>>>>>>> F: block/rbd.c
>>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>>
>>>>>>> Sheepdog
>>>>>>> M: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
>>>>>>> M: Liu Yuan <namei.unix@gmail.com>
>>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>> L: qemu-block@nongnu.org
>>>>>>> L: sheepdog@lists.wpkg.org
>>>>>>> S: Supported
>>>>>>> F: block/sheepdog.c
>>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>>
>>>>>>> VHDX
>>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>> L: qemu-block@nongnu.org
>>>>>>> S: Supported
>>>>>>> F: block/vhdx*
>>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>
>>>>>> Does "S: Supported" make sense without an M:?
>>>>>>
>>>>>>>
>>>>>>> VDI
>>>>>>> M: Stefan Weil <sw@weilnetz.de>
>>>>>>> @@ -2034,34 +2028,26 @@ F: docs/interop/nbd.txt
>>>>>>> T: git git://repo.or.cz/qemu/ericb.git nbd
>>>>>>>
>>>>>>> NFS
>>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>> M: Peter Lieven <pl@kamp.de>
>>>>>>> L: qemu-block@nongnu.org
>>>>>>> S: Maintained
>>>>>>> F: block/nfs.c
>>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>>
>>>>>>> SSH
>>>>>>> M: Richard W.M. Jones <rjones@redhat.com>
>>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>> L: qemu-block@nongnu.org
>>>>>>> S: Supported
>>>>>>> F: block/ssh.c
>>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>>
>>>>>>> CURL
>>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>> L: qemu-block@nongnu.org
>>>>>>> S: Supported
>>>>>>> F: block/curl.c
>>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>
>>>>>> Likewise.
>>>>>>
>>>>>>> GLUSTER
>>>>>>> -M: Jeff Cody <jcody@redhat.com>
>>>>>>> L: qemu-block@nongnu.org
>>>>>>> S: Supported
>>>>>>> F: block/gluster.c
>>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>>>>>>
>>>>>> Likewise.
>>>>>>
>>>>>>> Null Block Driver
>>>>>>> M: Fam Zheng <famz@redhat.com>
>>>>>>
>>>>>
>>>>> Block drivers without an M: naturally fall under the overall maintainership of
>>>>> block layer (Kevin&Max), so IMO keeping the statuses is fine. Maybe CURL can be
>>>>> degraded to Maintained, though.
>>>>
>>>> Yes, get_maintainer.pl combines all applicable sections. Human readers
>>>> are left to wonder, unless they know to look for other matches.
>>>>
>>>> Do we want to have a dedicated network block driver submaintainer again,
>>>> if we can find one?
>>>>
>>>> Do we want to have a dedicated VHDX driver submaintainer again? Fam,
>>>> you're maintaining VMDK, could you cover VHDX as well?
>>>
>>> Fam can't.
>>>
>>> I can see two sane options for the three sections that lose their sole
>>> maintainer (VHDX, CURL, GLUSTER):
>>>
>>> * Downgrade to S: Orphan
>>>
>>> This reflects the fact that we'd like to have dedicated maintainers
>>> for them. It camouflages the fact that the "Block layer core"
>>> maintainers pick up the slack.
>>>
>>> * Delete
>>>
>>> The opposite.
* Appoint suitable maintainers with the S: appropriate for them
Special case: appoint yourself. Doesn't actually change
maintaintership (you're already on the hook as core maintainers),
but it lets you adjust S:.
>>> Kevin, Max, please pick your poison, or suggest one you find tastier.
>>
>> Orphan is probably by far closer to the truth than Supported. But I
>> think what we really do is Odd Fixes. Not sure if that's a status that
>> works in any meaningful way without having a maintainer for the specific
>> thing assigned?
>
> IMHO "Odd Fixes" is still ok for entries that have at least a "L:" line,
> like "L: qemu-block@nongnu.org". If an entry neither got a "M:" nor a
> "L:" line anymore, it should be marked with "Orphan" instead.
Contradicts "Odd Fixes: It has a maintainer", but that's fixable or
perhaps tolerable.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] MAINTAINERS: Remove myself as block maintainer
2019-01-09 11:43 ` [Qemu-devel] [Qemu-block] " Niels de Vos
@ 2019-01-09 12:46 ` Markus Armbruster
0 siblings, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2019-01-09 12:46 UTC (permalink / raw)
To: Niels de Vos
Cc: Kevin Wolf, Fam Zheng, qemu-block, qemu-devel, mreitz, Jeff Cody
Niels de Vos <ndevos@redhat.com> writes:
> On Tue, Jan 08, 2019 at 08:12:16PM +0100, Kevin Wolf wrote:
>> Am 08.01.2019 um 18:18 hat Markus Armbruster geschrieben:
>> > This patch series got stuck.
>> >
>> > Markus Armbruster <armbru@redhat.com> writes:
>> >
>> > > Fam Zheng <famz@redhat.com> writes:
>> > >
>> > >> On Tue, 09/25 07:00, Markus Armbruster wrote:
>> > >>> Jeff Cody <jcody@redhat.com> writes:
>> > >>>
>> > >>> > I'll not be involved in day-to-day qemu development. Remove
>> > >>> > myself as maintainer from the remainder of the network block drivers
>> > >>> > (and vhdx), and revert them to the general block layer maintainership.
>> > >>> >
>> > >>> > Signed-off-by: Jeff Cody <jcody@redhat.com>
>> > >>> > ---
>> > >>> > MAINTAINERS | 14 --------------
>> > >>> > 1 file changed, 14 deletions(-)
>> > >>> >
>> > >>> > diff --git a/MAINTAINERS b/MAINTAINERS
>> > >>> > index e93f79672f..6ef6932628 100644
>> > >>> > --- a/MAINTAINERS
>> > >>> > +++ b/MAINTAINERS
>> > >>> > @@ -1982,28 +1982,22 @@ F: block/vmdk.c
>> > >>> >
>> > >>> > RBD
>> > >>> > M: Josh Durgin <jdurgin@redhat.com>
>> > >>> > -M: Jeff Cody <jcody@redhat.com>
>> > >>> > L: qemu-block@nongnu.org
>> > >>> > S: Supported
>> > >>> > F: block/rbd.c
>> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>> > >>> >
>> > >>> > Sheepdog
>> > >>> > M: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
>> > >>> > M: Liu Yuan <namei.unix@gmail.com>
>> > >>> > -M: Jeff Cody <jcody@redhat.com>
>> > >>> > L: qemu-block@nongnu.org
>> > >>> > L: sheepdog@lists.wpkg.org
>> > >>> > S: Supported
>> > >>> > F: block/sheepdog.c
>> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>> > >>> >
>> > >>> > VHDX
>> > >>> > -M: Jeff Cody <jcody@redhat.com>
>> > >>> > L: qemu-block@nongnu.org
>> > >>> > S: Supported
>> > >>> > F: block/vhdx*
>> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>> > >>>
>> > >>> Does "S: Supported" make sense without an M:?
>> > >>>
>> > >>> >
>> > >>> > VDI
>> > >>> > M: Stefan Weil <sw@weilnetz.de>
>> > >>> > @@ -2034,34 +2028,26 @@ F: docs/interop/nbd.txt
>> > >>> > T: git git://repo.or.cz/qemu/ericb.git nbd
>> > >>> >
>> > >>> > NFS
>> > >>> > -M: Jeff Cody <jcody@redhat.com>
>> > >>> > M: Peter Lieven <pl@kamp.de>
>> > >>> > L: qemu-block@nongnu.org
>> > >>> > S: Maintained
>> > >>> > F: block/nfs.c
>> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>> > >>> >
>> > >>> > SSH
>> > >>> > M: Richard W.M. Jones <rjones@redhat.com>
>> > >>> > -M: Jeff Cody <jcody@redhat.com>
>> > >>> > L: qemu-block@nongnu.org
>> > >>> > S: Supported
>> > >>> > F: block/ssh.c
>> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>> > >>> >
>> > >>> > CURL
>> > >>> > -M: Jeff Cody <jcody@redhat.com>
>> > >>> > L: qemu-block@nongnu.org
>> > >>> > S: Supported
>> > >>> > F: block/curl.c
>> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>> > >>>
>> > >>> Likewise.
>> > >>>
>> > >>> > GLUSTER
>> > >>> > -M: Jeff Cody <jcody@redhat.com>
>> > >>> > L: qemu-block@nongnu.org
>> > >>> > S: Supported
>> > >>> > F: block/gluster.c
>> > >>> > -T: git git://github.com/codyprime/qemu-kvm-jtc.git block
>> > >>>
>> > >>> Likewise.
>> > >>>
>> > >>> > Null Block Driver
>> > >>> > M: Fam Zheng <famz@redhat.com>
>> > >>>
>> > >>
>> > >> Block drivers without an M: naturally fall under the overall maintainership of
>> > >> block layer (Kevin&Max), so IMO keeping the statuses is fine. Maybe CURL can be
>> > >> degraded to Maintained, though.
>> > >
>> > > Yes, get_maintainer.pl combines all applicable sections. Human readers
>> > > are left to wonder, unless they know to look for other matches.
>> > >
>> > > Do we want to have a dedicated network block driver submaintainer again,
>> > > if we can find one?
>> > >
>> > > Do we want to have a dedicated VHDX driver submaintainer again? Fam,
>> > > you're maintaining VMDK, could you cover VHDX as well?
>> >
>> > Fam can't.
>> >
>> > I can see two sane options for the three sections that lose their sole
>> > maintainer (VHDX, CURL, GLUSTER):
>> >
>> > * Downgrade to S: Orphan
>> >
>> > This reflects the fact that we'd like to have dedicated maintainers
>> > for them. It camouflages the fact that the "Block layer core"
>> > maintainers pick up the slack.
>> >
>> > * Delete
>> >
>> > The opposite.
>> >
>> > Kevin, Max, please pick your poison, or suggest one you find tastier.
>>
>> Orphan is probably by far closer to the truth than Supported. But I
>> think what we really do is Odd Fixes. Not sure if that's a status that
>> works in any meaningful way without having a maintainer for the specific
>> thing assigned?
>
> For Gluster we are interested in keeping it maintained in some form. At
> least integration@gluster.org could be added as a list. I am not sure
> there is anyone working on Gluster that would fit for a maintainer of
> the driver. If you really want to put a name there, I can function as a
> 'maintainer' and pull in other Gluster developers in case I am otherwise
> occupied.
Leads us to the question what it takes to be a maintainer. I figure we
need at least a commitment to get patches reviewed, plus the ability to
get them reviewed competently.
Note my careful use of the passive voice: whether the maintainer does it
himself or herds a team of intelligent cats to do it may not matter all
that much to us.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-09 12:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1537848362.git.jcody@redhat.com>
[not found] ` <0e8a512d4c95094dc12f92390200c8e753c38248.1537848362.git.jcody@redhat.com>
[not found] ` <87efdiyxv9.fsf@dusky.pond.sub.org>
[not found] ` <20180925053204.GB4558@lemon.usersys.redhat.com>
[not found] ` <87va6uvxhv.fsf@dusky.pond.sub.org>
2019-01-08 17:18 ` [Qemu-devel] [PATCH 2/2] MAINTAINERS: Remove myself as block maintainer Markus Armbruster
2019-01-08 19:12 ` Kevin Wolf
2019-01-09 10:15 ` Thomas Huth
2019-01-09 12:39 ` Markus Armbruster
2019-01-09 11:43 ` [Qemu-devel] [Qemu-block] " Niels de Vos
2019-01-09 12:46 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).