From: "Richard W.M. Jones" <rjones@redhat.com>
To: eblake@redhat.com
Cc: kwolf@redhat.com, mreitz@redhat.com, qemu-block@nongnu.org,
qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v3] qemu-io: Add generic function for reinitializing optind.
Date: Wed, 9 Jan 2019 13:23:01 +0000 [thread overview]
Message-ID: <20190109132302.22634-1-rjones@redhat.com> (raw)
How about this one? Add a generic osdep function for reinitializing
optind, which does optreset on FreeBSD (but is identical on all other
OSes). Use it from qemu-io and qemu-img.
I have tested this on Linux, FreeBSD and OpenBSD.
checkpatch complains:
WARNING: Block comments use a leading /* on a separate line
#69: FILE: include/qemu/osdep.h:591:
+/**
WARNING: architecture specific defines should be avoided
#78: FILE: include/qemu/osdep.h:600:
+#ifdef __FreeBSD__
total: 0 errors, 2 warnings, 44 lines checked
but as far as I'm aware I've followed the correct formatting and
guidelines.
Rich.
next reply other threads:[~2019-01-09 13:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 13:23 Richard W.M. Jones [this message]
2019-01-09 13:23 ` [Qemu-devel] [PATCH v3] qemu-io: Add generic function for reinitializing optind Richard W.M. Jones
2019-01-09 13:44 ` Daniel P. Berrangé
2019-01-09 14:14 ` Richard W.M. Jones
2019-01-09 14:19 ` Daniel P. Berrangé
2019-01-09 14:53 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109132302.22634-1-rjones@redhat.com \
--to=rjones@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).