* [Qemu-devel] [PATCH] s390x/pci: Set the iommu region size as guest wants
@ 2019-01-08 17:33 Pierre Morel
2019-01-09 12:59 ` Cornelia Huck
0 siblings, 1 reply; 3+ messages in thread
From: Pierre Morel @ 2019-01-08 17:33 UTC (permalink / raw)
To: walling
Cc: borntraeger, cohuck, rth, david, qemu-s390x, qemu-devel, pasic,
thuth
The size of the accessible iommu memory region in the guest
is calculated by the gues as:
(PCI Address Limit) - (PCI Base Address) + 1.
Let's use this value to limit the IOMMU region size.
Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
---
hw/s390x/s390-pci-bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
index 69e0671..e97696a 100644
--- a/hw/s390x/s390-pci-bus.c
+++ b/hw/s390x/s390-pci-bus.c
@@ -660,7 +660,7 @@ void s390_pci_iommu_enable(S390PCIIOMMU *iommu)
char *name = g_strdup_printf("iommu-s390-%04x", iommu->pbdev->uid);
memory_region_init_iommu(&iommu->iommu_mr, sizeof(iommu->iommu_mr),
TYPE_S390_IOMMU_MEMORY_REGION, OBJECT(&iommu->mr),
- name, iommu->pal + 1);
+ name, iommu->pal - iommu->pba + 1);
iommu->enabled = true;
memory_region_add_subregion(&iommu->mr, 0, MEMORY_REGION(&iommu->iommu_mr));
g_free(name);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] s390x/pci: Set the iommu region size as guest wants
2019-01-08 17:33 [Qemu-devel] [PATCH] s390x/pci: Set the iommu region size as guest wants Pierre Morel
@ 2019-01-09 12:59 ` Cornelia Huck
2019-01-10 12:50 ` Pierre Morel
0 siblings, 1 reply; 3+ messages in thread
From: Cornelia Huck @ 2019-01-09 12:59 UTC (permalink / raw)
To: Pierre Morel
Cc: walling, borntraeger, rth, david, qemu-s390x, qemu-devel, pasic,
thuth
On Tue, 8 Jan 2019 18:33:39 +0100
Pierre Morel <pmorel@linux.ibm.com> wrote:
> The size of the accessible iommu memory region in the guest
> is calculated by the gues as:
s/gues/guest/
> (PCI Address Limit) - (PCI Base Address) + 1.
>
> Let's use this value to limit the IOMMU region size.
These are values provided by the guest in the mpcifc call, aren't they?
Let's mention that in the patch description, so it is more obvious :)
>
> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> ---
> hw/s390x/s390-pci-bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
> index 69e0671..e97696a 100644
> --- a/hw/s390x/s390-pci-bus.c
> +++ b/hw/s390x/s390-pci-bus.c
> @@ -660,7 +660,7 @@ void s390_pci_iommu_enable(S390PCIIOMMU *iommu)
> char *name = g_strdup_printf("iommu-s390-%04x", iommu->pbdev->uid);
> memory_region_init_iommu(&iommu->iommu_mr, sizeof(iommu->iommu_mr),
> TYPE_S390_IOMMU_MEMORY_REGION, OBJECT(&iommu->mr),
> - name, iommu->pal + 1);
> + name, iommu->pal - iommu->pba + 1);
> iommu->enabled = true;
> memory_region_add_subregion(&iommu->mr, 0, MEMORY_REGION(&iommu->iommu_mr));
> g_free(name);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] s390x/pci: Set the iommu region size as guest wants
2019-01-09 12:59 ` Cornelia Huck
@ 2019-01-10 12:50 ` Pierre Morel
0 siblings, 0 replies; 3+ messages in thread
From: Pierre Morel @ 2019-01-10 12:50 UTC (permalink / raw)
To: Cornelia Huck
Cc: walling, borntraeger, rth, david, qemu-s390x, qemu-devel, pasic,
thuth
On 09/01/2019 13:59, Cornelia Huck wrote:
> On Tue, 8 Jan 2019 18:33:39 +0100
> Pierre Morel <pmorel@linux.ibm.com> wrote:
>
>> The size of the accessible iommu memory region in the guest
>> is calculated by the gues as:
>
> s/gues/guest/
>
>> (PCI Address Limit) - (PCI Base Address) + 1.
>>
>> Let's use this value to limit the IOMMU region size.
>
> These are values provided by the guest in the mpcifc call, aren't they?
> Let's mention that in the patch description, so it is more obvious :)
>
OK thanks.
Regards,
Pierre
--
Pierre Morel
Linux/KVM/QEMU in Böblingen - Germany
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-10 12:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-08 17:33 [Qemu-devel] [PATCH] s390x/pci: Set the iommu region size as guest wants Pierre Morel
2019-01-09 12:59 ` Cornelia Huck
2019-01-10 12:50 ` Pierre Morel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).