qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	qemu-devel@nongnu.org, qemu-block@nongnu.org, armbru@redhat.com,
	eblake@redhat.com, mreitz@redhat.com, fam@euphon.net,
	stefanha@redhat.com, den@openvz.org
Subject: Re: [Qemu-devel] [PATCH] file-posix: add rough-block-status parameter
Date: Wed, 9 Jan 2019 17:51:11 +0100	[thread overview]
Message-ID: <20190109165111.GI4867@localhost.localdomain> (raw)
In-Reply-To: <5ddd78e0-90ed-a6e5-c454-f1a2e44c1a37@redhat.com>

Am 09.01.2019 um 17:42 hat Paolo Bonzini geschrieben:
> On 09/01/19 12:23, Kevin Wolf wrote:
> > Also note that this is only metadata preallocation; full preallocation
> > will still return allocated for the protocol layer and so it will always
> > be slow.
> 
> Full preallocation these days can create images with preallocated but
> known-zero blocks, I think?

That would defeat one of the main purposes of preallocation because it
would still require COW and metadata updates on the first write.

If there is demand, we could add something like preallocation=data where
data clusters are preallocated but COW/metadata updates still happen at
runtime, but so far nobody has asked for it. Not sure when you would use
it either.

Kevin

  reply	other threads:[~2019-01-09 16:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-08 19:45 [Qemu-devel] [PATCH] file-posix: add rough-block-status parameter Vladimir Sementsov-Ogievskiy
2019-01-08 20:11 ` Eric Blake
2019-01-09 11:23 ` Kevin Wolf
2019-01-09 16:42   ` Paolo Bonzini
2019-01-09 16:51     ` Kevin Wolf [this message]
2019-01-09 16:55       ` Paolo Bonzini
2019-01-09 17:09         ` Kevin Wolf
2019-01-09 18:09           ` Denis V.Lunev
2019-01-09 17:00       ` Eric Blake
2019-01-09 12:33 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190109165111.GI4867@localhost.localdomain \
    --to=kwolf@redhat.com \
    --cc=armbru@redhat.com \
    --cc=den@openvz.org \
    --cc=eblake@redhat.com \
    --cc=fam@euphon.net \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).