From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Cédric Le Goater" <clg@kaod.org>,
peter.maydell@linaro.org, "Thomas Huth" <thuth@redhat.com>,
qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
qemu-ppc@nongnu.org, "Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99
Date: Thu, 10 Jan 2019 10:12:43 +0000 [thread overview]
Message-ID: <20190110101243.GE2178@redhat.com> (raw)
In-Reply-To: <60b7e2bf-6822-6e0b-7184-b38594eb38ed@redhat.com>
On Wed, Jan 09, 2019 at 03:25:53PM -0600, Eric Blake wrote:
> On 1/9/19 3:20 PM, Paolo Bonzini wrote:
> > On 09/01/19 18:28, Daniel P. Berrangé wrote:
> >>> so both files include each other, how nice ...
> >> If the header files are mutually dependent it makes me wonder what the
> >> point of having them split up is ?
> >>
> >> Feels like either they need to be merged, or they need to be split up
> >> and refactored even more to remove the mutual dependancy.
> >
> > If they include each other only for the typedefs, then prehaps the
> > solution is to change the coding style and allow using struct in
> > function prototypes. I'm pretty sure there are several examples of this
> > already.
>
> Or stick the typedef in <typedefs.h>, instead of trying to find (or
> create) some other common header.
Probably better to just have a local spapr_types.h instead of
polluting the global namespace.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2019-01-10 10:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 16:39 [Qemu-devel] [PATCH v3 0/2] Force the C standard to gnu99 Thomas Huth
2019-01-09 16:39 ` [Qemu-devel] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99 Thomas Huth
2019-01-09 17:13 ` [Qemu-devel] [Qemu-ppc] " Cédric Le Goater
2019-01-09 17:28 ` Daniel P. Berrangé
2019-01-09 17:40 ` Cédric Le Goater
2019-01-09 17:47 ` Greg Kurz
2019-01-10 6:47 ` Thomas Huth
2019-01-09 21:20 ` Paolo Bonzini
2019-01-09 21:25 ` Eric Blake
2019-01-09 21:31 ` Paolo Bonzini
2019-01-10 10:12 ` Daniel P. Berrangé [this message]
2019-01-10 12:12 ` Greg Kurz
2019-01-10 6:46 ` Thomas Huth
2019-01-09 17:46 ` Cédric Le Goater
2019-01-09 16:39 ` [Qemu-devel] [PATCH v3 2/2] configure: Force the C standard to gnu99 Thomas Huth
2019-01-09 18:10 ` Philippe Mathieu-Daudé
2019-01-09 21:26 ` Paolo Bonzini
2019-01-10 6:50 ` Thomas Huth
2019-01-09 21:23 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110101243.GE2178@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=clg@kaod.org \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).