From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 06/10] spapr: Eliminate SPAPR_PCI_2_7_MMIO_WIN_SIZE macro
Date: Thu, 10 Jan 2019 12:29:51 -0200 [thread overview]
Message-ID: <20190110142955.23254-7-ehabkost@redhat.com> (raw)
In-Reply-To: <20190110142955.23254-1-ehabkost@redhat.com>
The macro is only used in one place, where the purpose of the
value is obvious. Eliminate the macro so we don't need to rely
on stringify().
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20190107193020.21744-2-ehabkost@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
include/hw/pci-host/spapr.h | 1 -
hw/ppc/spapr.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/hw/pci-host/spapr.h b/include/hw/pci-host/spapr.h
index 4eb3a2ce3e..a5a7bf4837 100644
--- a/include/hw/pci-host/spapr.h
+++ b/include/hw/pci-host/spapr.h
@@ -101,7 +101,6 @@ struct sPAPRPHBState {
#define SPAPR_MAX_PHBS ((SPAPR_PCI_LIMIT - SPAPR_PCI_BASE) / \
SPAPR_PCI_MEM64_WIN_SIZE - 1)
-#define SPAPR_PCI_2_7_MMIO_WIN_SIZE 0xf80000000
#define SPAPR_PCI_IO_WIN_SIZE 0x10000
#define SPAPR_PCI_MSI_WINDOW 0x40000000000ULL
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 83081defde..54a19d2db8 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -4285,7 +4285,7 @@ static void spapr_machine_2_7_class_options(MachineClass *mc)
{
.driver = TYPE_SPAPR_PCI_HOST_BRIDGE,
.property = "mem_win_size",
- .value = stringify(SPAPR_PCI_2_7_MMIO_WIN_SIZE),
+ .value = "0xf80000000",
},
{
.driver = TYPE_SPAPR_PCI_HOST_BRIDGE,
--
2.18.0.rc1.1.g3f1ff2140
next prev parent reply other threads:[~2019-01-10 14:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 14:29 [Qemu-devel] [PULL 00/10] Machine queue, 2019-01-10 Eduardo Habkost
2019-01-10 14:29 ` [Qemu-devel] [PULL 01/10] qemu-deprecated.texi: Rename the HMP section Eduardo Habkost
2019-01-10 14:29 ` [Qemu-devel] [PULL 02/10] Update that HMP 'cpu-add' is deprecated in 4.0 Eduardo Habkost
2019-01-10 14:29 ` [Qemu-devel] [PULL 03/10] Mention that QMP 'cpu-add' will be deprecated Eduardo Habkost
2019-01-10 14:29 ` [Qemu-devel] [PULL 04/10] range: add some more functions Eduardo Habkost
2019-01-10 14:29 ` [Qemu-devel] [PULL 05/10] memory-device: rewrite address assignment using ranges Eduardo Habkost
2019-01-10 14:29 ` Eduardo Habkost [this message]
2019-01-10 14:29 ` [Qemu-devel] [PULL 07/10] machine: Eliminate unnecessary stringify() usage Eduardo Habkost
2019-01-10 14:29 ` [Qemu-devel] [PULL 08/10] machine: Use shorter format for GlobalProperty arrays Eduardo Habkost
2019-01-10 14:29 ` [Qemu-devel] [PULL 09/10] qdev: fix -device scsi-hd, help regression Eduardo Habkost
2019-01-10 14:29 ` [Qemu-devel] [PULL 10/10] qom: Don't keep error value between object_property_parse() calls Eduardo Habkost
2019-01-11 15:45 ` [Qemu-devel] [PULL 00/10] Machine queue, 2019-01-10 Peter Maydell
2019-01-11 22:42 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110142955.23254-7-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).