From: Cornelia Huck <cohuck@redhat.com>
To: Li Qiang <liq3ea@163.com>
Cc: walling@linux.ibm.com, rth@twiddle.net, david@redhat.com,
pasic@linux.ibm.com, borntraeger@de.ibm.com,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] s390: avoid potential null dereference ins390_pcihost_unplug()
Date: Thu, 10 Jan 2019 16:18:47 +0100 [thread overview]
Message-ID: <20190110161847.51912076.cohuck@redhat.com> (raw)
In-Reply-To: <20190108151114.33140-1-liq3ea@163.com>
On Tue, 8 Jan 2019 07:11:14 -0800
Li Qiang <liq3ea@163.com> wrote:
> When getting the 'pbdev', the if...else has no default branch.
> From Coverity, the 'pbdev' maybe null when the 'dev' is not
> the TYPE_PCI_BRIDGE/TYPE_PCI_DEVICE/TYPE_S390_PCI_DEVICE.
> This patch adds a default branch for device plug and unplug.
>
> Spotted by Coverity: CID 1398593
>
> Signed-off-by: Li Qiang <liq3ea@163.com>
> ---
>
> Change since v2: use g_assert_not_reached for default branch
>
> hw/s390x/s390-pci-bus.c | 4 ++++
> 1 file changed, 4 insertions(+)
Thanks, applied.
prev parent reply other threads:[~2019-01-10 15:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 15:11 [Qemu-devel] [PATCH v3] s390: avoid potential null dereference ins390_pcihost_unplug() Li Qiang
2019-01-08 15:49 ` David Hildenbrand
2019-01-08 16:22 ` Halil Pasic
2019-01-09 16:07 ` Collin Walling
2019-01-10 15:18 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110161847.51912076.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=liq3ea@163.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).