From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:39172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gheha-0004EU-21 for qemu-devel@nongnu.org; Thu, 10 Jan 2019 13:05:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ghehZ-0000m7-89 for qemu-devel@nongnu.org; Thu, 10 Jan 2019 13:05:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42832) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ghehY-0000lS-Uz for qemu-devel@nongnu.org; Thu, 10 Jan 2019 13:05:09 -0500 From: Eduardo Habkost Date: Thu, 10 Jan 2019 16:04:56 -0200 Message-Id: <20190110180458.18762-1-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH v3 0/2] Fix virtio-*(-non)-transitional crash on 2.6 machine-types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Thomas Huth , Eduardo Habkost , Marcel Apfelbaum , "Michael S. Tsirkin" , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Dr. David Alan Gilbert" , Cornelia Huck Changes v2 -> v3: * Don't ignore all errors: only ignore optional properties if they don't exist * Patch 1/3 from v2 was already merged on machine-next Description of v2: This is a second attempt to fix the crash reported by Thomas[1]. This keeps the compat property array simple, different from my first attempt[2]. This also avoids extra complexity on the device code: we don't need interface name, inheritance tricks, or devices overriding a compat property after the fact. The simple absence of the QOM properties on some device types is enough to make the compat code skip them. This series is based on my machine-next branch, because of conflicts with compat property array cleanups that are already queued. [1] http://mid.mail-archive.com/a28d196a-e2fe-a013-a6e2-99ac260f6279@redhat.com [2] http://mid.mail-archive.com/20190104032226.21428-1-ehabkost@redhat.com Eduardo Habkost (2): globals: Allow global properties to be optional virtio: Make disable-legacy/disable-modern compat properties optional include/hw/qdev-core.h | 3 +++ hw/core/machine.c | 5 +++-- qom/object.c | 3 +++ 3 files changed, 9 insertions(+), 2 deletions(-) -- 2.18.0.rc1.1.g3f1ff2140