From: David Gibson <david@gibson.dropbear.id.au>
To: Laurent Vivier <laurent@vivier.eu>
Cc: Roman Kapl <roman.kapl@sysgo.com>,
Jon Diekema <jon.diekema@gmail.com>,
qemu-trivial@nongnu.org, Roman Kapl <rka@sysgo.com>,
"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-trivial] ppc: e6500 registers SPR 604 twice
Date: Fri, 11 Jan 2019 11:35:27 +1100 [thread overview]
Message-ID: <20190111003527.GO6682@umbus.fritz.box> (raw)
In-Reply-To: <f36c1752-98ad-7c44-4637-7186c7511f38@vivier.eu>
[-- Attachment #1: Type: text/plain, Size: 2294 bytes --]
On Wed, Jan 09, 2019 at 11:17:00AM +0100, Laurent Vivier wrote:
> David,
>
> will you take this through your ppc branch?
Somehow I missed this one, sorry. Even when I look back through my
mail archives I can't see the original message of this thread. Can
you resend please?
>
> Thanks,
> Laurent
>
> On 04/01/2019 11:41, Roman Kapl wrote:
> >> Le 25/12/2018 à 10:50, Jon Diekema a écrit :
> >>> From f399f28441e0aa79458d68996038ca3606fcb699 Mon Sep 17 00:00:00 2001
> >>> From: Jon Diekema <jon.diekema@ge.com <mailto:jon.diekema@ge.com>>
> >>> Date: Tue, 25 Dec 2018 04:36:06 -0500
> >>> Subject: ppc: e6500 registers SPR 604 twice
> >>>
> >>> When using the e6500 CPU, QEMU generates a fatal error after
> >>> complaining about registering SPR 604 twice.
> >>>
> >>>
> >>> diff --git a/target/ppc/translate_init.inc.c
> >>> b/target/ppc/translate_init.inc.c
> >>> index 03f1d34a97..c971a5faf7 100644
> >>> --- a/target/ppc/translate_init.inc.c
> >>> +++ b/target/ppc/translate_init.inc.c
> >>> @@ -4947,14 +4947,6 @@ static void init_proc_e500(CPUPPCState *env, int
> >>> version)
> >>> }
> >>> if (version == fsl_e6500) {
> >>> - spr_register(env, SPR_BOOKE_SPRG8, "SPRG8",
> >>> - SPR_NOACCESS, SPR_NOACCESS,
> >>> - &spr_read_generic, &spr_write_generic,
> >>> - 0x00000000);
> >>> - spr_register(env, SPR_BOOKE_SPRG9, "SPRG9",
> >>> - SPR_NOACCESS, SPR_NOACCESS,
> >>> - &spr_read_generic, &spr_write_generic,
> >>> - 0x00000000);
> >>> /* Thread identification */
> >>> spr_register(env, SPR_TIR, "TIR",
> >>> SPR_NOACCESS, SPR_NOACCESS,
> >>> --
> >>> 2.20.1.3.gf17a2b179
> >>>
> >>
> >> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
> >> Tested-by: Laurent Vivier <laurent@vivier.eu>
> >>
> >
> > Thanks Jon, I did not test with e6500. The patch fixes the issue &
> > debugging still works on e5500.
> >
> > Roman Kapl
> >
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-01-11 0:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CALvuzg43uSodseEHjNaRcPFBKKPTY2mcppUbYgiLL=QO9RxX_Q@mail.gmail.com>
2019-01-03 17:16 ` [Qemu-devel] [Qemu-trivial] ppc: e6500 registers SPR 604 twice Laurent Vivier
2019-01-04 10:41 ` Roman Kapl
2019-01-09 10:17 ` Laurent Vivier
2019-01-11 0:35 ` David Gibson [this message]
2019-01-11 7:19 ` Laurent Vivier
2019-01-17 17:51 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190111003527.GO6682@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=jon.diekema@gmail.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rka@sysgo.com \
--cc=roman.kapl@sysgo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).