From: David Gibson <david@gibson.dropbear.id.au>
To: Laurent Vivier <laurent@vivier.eu>
Cc: Jon Diekema <jon.diekema@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>,
"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] Whitespace cleanup: target/ppc/translate_init.inc.c
Date: Fri, 11 Jan 2019 11:37:35 +1100 [thread overview]
Message-ID: <20190111003735.GP6682@umbus.fritz.box> (raw)
In-Reply-To: <2c434536-6388-563f-344b-c6800769a733@vivier.eu>
[-- Attachment #1: Type: text/plain, Size: 1970 bytes --]
On Wed, Jan 09, 2019 at 11:15:26AM +0100, Laurent Vivier wrote:
> Hi Jon,
>
> please cc: qemu-devel and MAINTAINERS when you send a patch.
>
> You can have the list of maintainers using a script in qemu directory:
>
> ./scripts/get_maintainer.pl XXXX.patch
>
> Thanks,
> Laurent
Hrm. Like the other patch, I didn't seem to receive this - I checked
back through my archives. I think something must be not working with
email from Jon to me, although I can't quite imagine what.
>
> On 03/01/2019 20:58, Jon Diekema wrote:
> > From: Jon Diekema <jon.diekema@gmail.com>
> > Date: Tue, 25 Dec 2018 04:03:04 -0500
> > Subject: Whitespace cleanup: target/ppc/translate_init.inc.c
> >
> > Signed-off-by: Jon Diekema <jon.diekema@gmail.com>
> > ---
> > target/ppc/translate_init.inc.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/target/ppc/translate_init.inc.c b/target/ppc/translate_init.inc.c
> > index c971a5faf7..b5f4c9bd55 100644
> > --- a/target/ppc/translate_init.inc.c
> > +++ b/target/ppc/translate_init.inc.c
> > @@ -5237,7 +5237,7 @@ static void init_proc_601(CPUPPCState *env)
> > 0x00000000);
> > /* Memory management */
> > init_excp_601(env);
> > - /* XXX: beware that dcache line size is 64
> > + /* XXX: beware that dcache line size is 64
> > * but dcbz uses 32 bytes "sectors"
> > * XXX: this breaks clcs instruction !
> > */
> > @@ -10485,7 +10485,7 @@ static void ppc_cpu_class_init(ObjectClass *oc, void *data)
> > cc->tcg_initialize = ppc_translate_init;
> > #endif
> > cc->disas_set_info = ppc_disas_set_info;
> > -
> > +
> > dc->fw_name = "PowerPC,UNKNOWN";
> > }
> >
> >
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-01-11 0:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5c2e6965.1c69fb81.b832c.13ee@mx.google.com>
2019-01-09 10:15 ` [Qemu-devel] [Qemu-trivial] Whitespace cleanup: target/ppc/translate_init.inc.c Laurent Vivier
2019-01-11 0:37 ` David Gibson [this message]
2019-01-11 7:20 ` Laurent Vivier
2019-01-11 13:05 ` Philippe Mathieu-Daudé
[not found] <CALvuzg6x2NjiJR=fPkgEmW2fCn6Uzy+rLAPHsC6Qn-S6hiNoqQ@mail.gmail.com>
2019-01-03 17:22 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190111003735.GP6682@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=jon.diekema@gmail.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).