From: Cornelia Huck <cohuck@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] pc-bios/s390-ccw: Use proper register names for Clang
Date: Fri, 11 Jan 2019 12:44:55 +0100 [thread overview]
Message-ID: <20190111124455.4ad73520.cohuck@redhat.com> (raw)
In-Reply-To: <1547123559-30476-1-git-send-email-thuth@redhat.com>
On Thu, 10 Jan 2019 13:32:39 +0100
Thomas Huth <thuth@redhat.com> wrote:
> When compiling the s390-ccw firmware with Clang 7.0.1, I get the
> following errors:
>
> pc-bios/s390-ccw/start.S:62:19: error: invalid use of length addressing
> stctg 0,0,0(15)
> ^
> pc-bios/s390-ccw/start.S:63:12: error: invalid use of length addressing
> oi 6(15), 0x2
> ^
> pc-bios/s390-ccw/start.S:64:19: error: invalid use of length addressing
> lctlg 0,0,0(15)
> ^
> pc-bios/s390-ccw/start.S:76:19: error: invalid use of length addressing
> stctg 0,0,0(15)
> ^
> pc-bios/s390-ccw/start.S:77:12: error: invalid use of length addressing
> ni 6(15), 0xfd
> ^
> pc-bios/s390-ccw/start.S:78:19: error: invalid use of length addressing
> lctlg 0,0,0(15)
> ^
> pc-bios/s390-ccw/start.S:79:12: error: invalid operand for instruction
> br 14
> ^
>
> Let's use proper register names like in the rest of this file to fix it.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> pc-bios/s390-ccw/start.S | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
Thanks, applied.
prev parent reply other threads:[~2019-01-11 11:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 12:32 [Qemu-devel] [PATCH] pc-bios/s390-ccw: Use proper register names for Clang Thomas Huth
2019-01-10 12:42 ` Christian Borntraeger
2019-01-11 11:44 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190111124455.4ad73520.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).