From: Yuval Shaia <yuval.shaia@oracle.com>
To: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org, cohuck@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/3] contrib/rdmacm-mux: fix clang compilation
Date: Sun, 13 Jan 2019 21:26:45 +0200 [thread overview]
Message-ID: <20190113192644.GC10017@lap1> (raw)
In-Reply-To: <20190112150225.20294-4-marcel.apfelbaum@gmail.com>
On Sat, Jan 12, 2019 at 05:02:25PM +0200, Marcel Apfelbaum wrote:
> Fix Commit a5d2f6f877 (contrib/rdmacm-mux: Add implementation
> of RDMA User MAD multiplexer).
>
> The above commit introduces a new contrib target, adding a global dependency
> to libumad library in case pvrdma configuration option is enabled.
> Clang forbids it:
> clang-6.0: error: -libumad: 'linker' input unused
> [-Werror,-Wunused-command-line-argument]
>
> Fix by limiting the scope to the rdmacm-mux target itself.
>
> Reported-by: Cornelia Huck <cohuck@redhat.com>
> Signed-off-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
> ---
> Makefile | 2 ++
> contrib/rdmacm-mux/Makefile.objs | 1 -
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index a9ac16d94e..31e87e0c2d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -580,6 +580,8 @@ vhost-user-scsi$(EXESUF): $(vhost-user-scsi-obj-y) libvhost-user.a
> $(call LINK, $^)
> vhost-user-blk$(EXESUF): $(vhost-user-blk-obj-y) libvhost-user.a
> $(call LINK, $^)
> +
> +rdmacm-mux$(EXESUF): LIBS += "-libumad"
> rdmacm-mux$(EXESUF): $(rdmacm-mux-obj-y) $(COMMON_LDADDS)
> $(call LINK, $^)
>
> diff --git a/contrib/rdmacm-mux/Makefile.objs b/contrib/rdmacm-mux/Makefile.objs
> index e1ff4fe569..3df744af89 100644
> --- a/contrib/rdmacm-mux/Makefile.objs
> +++ b/contrib/rdmacm-mux/Makefile.objs
> @@ -1,4 +1,3 @@
> ifdef CONFIG_PVRDMA
> -CFLAGS += -libumad
My bad, thanks for doing it the right way.
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
> rdmacm-mux-obj-y = main.o
> endif
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-01-13 19:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-12 15:02 [Qemu-devel] [PATCH 0/3] contrib/rdmacm-mux: fix clang compilation Marcel Apfelbaum
2019-01-12 15:02 ` [Qemu-devel] [PATCH 1/3] contrib/rdmacm-mux: remove Wno-format-truncation flag Marcel Apfelbaum
2019-01-13 20:32 ` Yuval Shaia
2019-01-12 15:02 ` [Qemu-devel] [PATCH 2/3] hw/rdma: modify struct initialization Marcel Apfelbaum
2019-01-13 19:24 ` Yuval Shaia
2019-01-13 19:36 ` Yuval Shaia
2019-01-14 21:23 ` Marcel Apfelbaum
2019-01-14 11:47 ` Cornelia Huck
2019-01-14 21:22 ` Marcel Apfelbaum
2019-01-12 15:02 ` [Qemu-devel] [PATCH 3/3] contrib/rdmacm-mux: fix clang compilation Marcel Apfelbaum
2019-01-13 19:26 ` Yuval Shaia [this message]
2019-01-14 11:42 ` [Qemu-devel] [PATCH 0/3] " Cornelia Huck
2019-01-14 21:26 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190113192644.GC10017@lap1 \
--to=yuval.shaia@oracle.com \
--cc=cohuck@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).