qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>, quintela@redhat.com, kwolf@redhat.com
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] 3.1: second invocation of migrate crashes qemu
Date: Mon, 14 Jan 2019 10:51:32 +0000	[thread overview]
Message-ID: <20190114105132.GA2524@work-vm> (raw)
In-Reply-To: <e5021228-184b-cc1b-7aba-3bba795127a6@msgid.tls.msk.ru>

* Michael Tokarev (mjt@tls.msk.ru) wrote:
> $ qemu-system-x86_64 -monitor stdio -hda foo.img
> QEMU 3.1.0 monitor - type 'help' for more information
> (qemu) stop
> (qemu) migrate "exec:cat >/dev/null"
> (qemu) migrate "exec:cat >/dev/null"
> qemu-system-x86_64: /build/qemu/qemu-3.1/block.c:4647: bdrv_inactivate_recurse: Assertion `!(bs->open_flags & BDRV_O_INACTIVE)' failed.
> Aborted

And on head as well;  it only happens if the 1st migrate is succesful;
if it got cancelled the 2nd one works, so it's not too bad.

I suspect the problem here is all around locking/ownership - the block
devices get shutdown at the end of migration since the assumption is
that the other end has them open now and we had better release them.

Dave

> (it is irrelevant what's in foo.img, it only needs to be initialized).
> 
> If it is worth to bisect I'll do that tomorrow.
> 
> Thanks,
> 
> /mjt
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

  reply	other threads:[~2019-01-14 10:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-12 17:11 [Qemu-devel] 3.1: second invocation of migrate crashes qemu Michael Tokarev
2019-01-14 10:51 ` Dr. David Alan Gilbert [this message]
2019-01-14 11:52   ` Kevin Wolf
2019-01-18 15:57     ` Dr. David Alan Gilbert
2019-01-21 15:55       ` Kevin Wolf
2019-01-21 16:05         ` Dr. David Alan Gilbert
2019-01-21 16:45           ` Kevin Wolf
2019-01-24 20:04             ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190114105132.GA2524@work-vm \
    --to=dgilbert@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).