From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:48102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gizJW-0001NB-4q for qemu-devel@nongnu.org; Mon, 14 Jan 2019 05:17:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gizJV-0007Kx-8E for qemu-devel@nongnu.org; Mon, 14 Jan 2019 05:17:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40412) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gizJV-0007KO-01 for qemu-devel@nongnu.org; Mon, 14 Jan 2019 05:17:49 -0500 Date: Mon, 14 Jan 2019 11:17:35 +0100 From: Igor Mammedov Message-ID: <20190114111735.531c4cca@redhat.com> In-Reply-To: <20190109193115.20655-6-marcandre.lureau@redhat.com> References: <20190109193115.20655-1-marcandre.lureau@redhat.com> <20190109193115.20655-6-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v16 5/6] acpi: add ACPI memory clear interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau Cc: qemu-devel@nongnu.org, Paolo Bonzini , Eduardo Habkost , Marcel Apfelbaum , stefanb@linux.vnet.ibm.com, f4bug@amsat.org, "Michael S. Tsirkin" , Stefan Berger , Richard Henderson On Wed, 9 Jan 2019 23:31:14 +0400 Marc-Andr=C3=A9 Lureau wrote: > The interface is described in the "TCG Platform Reset Attack > Mitigation Specification", chapter 6 "ACPI _DSM Function". According I'd add a spec version here as well adn maybe a link like it's in 4/6 (but links are often go stale so it's not must have, just name and version should be sufficient to find the spec) > to Laszlo, it's not so easy to implement in OVMF, he suggested to do > it in qemu instead. >=20 > See specification documentation for more details, and next commit for > memory clear on reset handling. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > Reviewed-by: Michael S. Tsirkin > Tested-by: Stefan Berger With commit amended=20 Reviewed-by: Igor Mammedov > --- > hw/acpi/tpm.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++ > docs/specs/tpm.txt | 2 ++ > 2 files changed, 57 insertions(+) >=20 > diff --git a/hw/acpi/tpm.c b/hw/acpi/tpm.c > index 9f205378f2..b96459e45b 100644 > --- a/hw/acpi/tpm.c > +++ b/hw/acpi/tpm.c > @@ -53,6 +53,16 @@ void tpm_build_ppi_acpi(TPMIf *tpm, Aml *dev) > pprq =3D aml_name("PPRQ"); > pprm =3D aml_name("PPRM"); > =20 > + aml_append(dev, > + aml_operation_region( > + "TPP3", AML_SYSTEM_MEMORY, > + aml_int(TPM_PPI_ADDR_BASE + > + 0x15a /* movv, docs/specs/tpm.txt */), > + 0x1)); > + field =3D aml_field("TPP3", AML_BYTE_ACC, AML_NOLOCK, AML_PRESERVE); > + aml_append(field, aml_named_field("MOVV", 8)); > + aml_append(dev, field); > + > /* > * DerefOf in Windows is broken with SYSTEM_MEMORY. Use a dynamic > * operation region inside of a method for getting FUNC[op]. > @@ -399,6 +409,51 @@ void tpm_build_ppi_acpi(TPMIf *tpm, Aml *dev) > aml_append(ifctx, aml_return(aml_buffer(1, zerobyte))); > } > aml_append(method, ifctx); > + > + /* > + * "TCG Platform Reset Attack Mitigation Specification 1.00", > + * Chapter 6 "ACPI _DSM Function" > + */ > + ifctx =3D aml_if( > + aml_equal(uuid, > + aml_touuid("376054ED-CC13-4675-901C-4756D7F2D45D")= )); > + { > + /* standard DSM query function */ > + ifctx2 =3D aml_if(aml_equal(function, zero)); > + { > + uint8_t byte_list[1] =3D { 0x03 }; /* functions 1-2 supp= orted */ > + > + aml_append(ifctx2, > + aml_return(aml_buffer(sizeof(byte_list), > + byte_list))); > + } > + aml_append(ifctx, ifctx2); > + > + /* > + * TCG Platform Reset Attack Mitigation Specification 1.0 Ch= .6 > + * > + * Arg 2 (Integer): Function Index =3D 1 > + * Arg 3 (Package): Arguments =3D Package: Type: Integer > + * Operation Value of the Request > + * Returns: Type: Integer > + * 0: Success > + * 1: General Failure > + */ > + ifctx2 =3D aml_if(aml_equal(function, one)); > + { > + aml_append(ifctx2, > + aml_store(aml_derefof(aml_index(arguments, ze= ro)), > + op)); > + { > + aml_append(ifctx2, aml_store(op, aml_name("MOVV"))); > + > + /* 0: success */ > + aml_append(ifctx2, aml_return(zero)); > + } > + } > + aml_append(ifctx, ifctx2); > + } > + aml_append(method, ifctx); > } > aml_append(dev, method); > } > diff --git a/docs/specs/tpm.txt b/docs/specs/tpm.txt > index 424d1511fc..5d8c26b1ad 100644 > --- a/docs/specs/tpm.txt > +++ b/docs/specs/tpm.txt > @@ -135,6 +135,8 @@ layout: > +----------+--------+--------+-----------------------------------------= --+ > | next_step| 0x1 | 0x159 | Operation to execute after reboot by = | > | | | | firmware. Used by firmware. = | > + +----------+--------+--------+-----------------------------------------= --+ > + | movv | 0x1 | 0x15a | Memory overwrite variable = | > +----------+--------+--------+-----------------------------------------= --+ > =20 > The following values are supported for the 'func' field. They corresp= ond