qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Michael Tokarev <mjt@tls.msk.ru>,
	quintela@redhat.com, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] 3.1: second invocation of migrate crashes qemu
Date: Mon, 14 Jan 2019 12:52:05 +0100	[thread overview]
Message-ID: <20190114115205.GD6837@linux.fritz.box> (raw)
In-Reply-To: <20190114105132.GA2524@work-vm>

Am 14.01.2019 um 11:51 hat Dr. David Alan Gilbert geschrieben:
> * Michael Tokarev (mjt@tls.msk.ru) wrote:
> > $ qemu-system-x86_64 -monitor stdio -hda foo.img
> > QEMU 3.1.0 monitor - type 'help' for more information
> > (qemu) stop
> > (qemu) migrate "exec:cat >/dev/null"
> > (qemu) migrate "exec:cat >/dev/null"
> > qemu-system-x86_64: /build/qemu/qemu-3.1/block.c:4647: bdrv_inactivate_recurse: Assertion `!(bs->open_flags & BDRV_O_INACTIVE)' failed.
> > Aborted
> 
> And on head as well;  it only happens if the 1st migrate is succesful;
> if it got cancelled the 2nd one works, so it's not too bad.
> 
> I suspect the problem here is all around locking/ownership - the block
> devices get shutdown at the end of migration since the assumption is
> that the other end has them open now and we had better release them.

Yes, only "cont" gets control back to the source VM.

I think we really should limit the possible monitor commands in the
postmigrate status, and possibly provide a way to get back to the
regular paused state (which means getting back control of the resources)
without resuming the VM first.

Kevin

  reply	other threads:[~2019-01-14 11:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-12 17:11 [Qemu-devel] 3.1: second invocation of migrate crashes qemu Michael Tokarev
2019-01-14 10:51 ` Dr. David Alan Gilbert
2019-01-14 11:52   ` Kevin Wolf [this message]
2019-01-18 15:57     ` Dr. David Alan Gilbert
2019-01-21 15:55       ` Kevin Wolf
2019-01-21 16:05         ` Dr. David Alan Gilbert
2019-01-21 16:45           ` Kevin Wolf
2019-01-24 20:04             ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190114115205.GD6837@linux.fritz.box \
    --to=kwolf@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).