From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: qemu-devel@nongnu.org, "Daniel P. Berrangé" <berrange@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Fam Zheng" <fam@euphon.net>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [Qemu-devel] [PULL 12/21] travis: stop redefining the script commands
Date: Mon, 14 Jan 2019 15:01:20 +0000 [thread overview]
Message-ID: <20190114150129.1013-13-alex.bennee@linaro.org> (raw)
In-Reply-To: <20190114150129.1013-1-alex.bennee@linaro.org>
From: Daniel P. Berrangé <berrange@redhat.com>
One of the matrix entries redefines the script command in order to add
the ${MAKEFLAGS} variable. Ideally ${MAKEFLAGS} would be referenced by
the definition of the ${TEST_CMD} env variable, but this isn't possible
in travis. ${MAKEFLAGS} exists to eliminate duplication of flags in
every "make" command, but this cure causes a worse problem, namely the
reduplication of the "script" command. It is simpler to just insert "-j3"
directly into any "make" command.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
diff --git a/.travis.yml b/.travis.yml
index 2ef7997d25..7b18d33e9d 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -65,8 +65,7 @@ env:
global:
- SRC_DIR="."
- BUILD_DIR="."
- - TEST_CMD="make check"
- - MAKEFLAGS="-j3"
+ - TEST_CMD="make check -j3"
git:
@@ -78,7 +77,7 @@ before_script:
- mkdir -p ${BUILD_DIR} && cd ${BUILD_DIR}
- ${SRC_DIR}/configure ${CONFIG} || { cat config.log && exit 1; }
script:
- - make ${MAKEFLAGS} && ${TEST_CMD}
+ - make -j3 && ${TEST_CMD}
matrix:
@@ -255,9 +254,7 @@ matrix:
- env:
- CONFIG="--disable-system --disable-docs"
- - TEST_CMD="make check-tcg"
- script:
- - make ${MAKEFLAGS} && ${TEST_CMD} ${MAKEFLAGS}
+ - TEST_CMD="make -j3 check-tcg"
sudo: required
dist: trusty
compiler: gcc
--
2.17.1
next prev parent reply other threads:[~2019-01-14 15:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 15:01 [Qemu-devel] [PULL 00/21] misc testing fixes for Travis and docker Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 01/21] docker: Use stable git tag for virglrenderer Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 02/21] tests: run ldconfig after installing extra software Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 03/21] tests: remove obsolete 'debian' dockerfile Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 04/21] tests: update Fedora dockerfile to use Fedora 29 Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 05/21] tests: update Fedora i386 cross image to " Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 06/21] tests: use in-place sed magic for enabling deb-src in travis image Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 07/21] travis: add whitespace between each major section & matrix entry Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 08/21] travis: define all the build matrix entries in one place Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 09/21] travis: standardize the syntax used for env variables Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 10/21] travis: don't clone git submodules upfront Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 11/21] travis: use homebrew addon for MacOSX Alex Bennée
2019-01-14 15:01 ` Alex Bennée [this message]
2019-01-14 15:01 ` [Qemu-devel] [PULL 13/21] travis: stop using container based envs Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 14/21] travis: run tests in verbose mode Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 15/21] travis: remove matrix settings that duplicate global settings Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 16/21] docker: Use a stable snapshot for Debian Sid Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 17/21] travis: bump to Xenial baseline Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 18/21] tests/docker: update our Travis image Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 19/21] tests/docker: remove SID_AGE test hack Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 20/21] tests: use g_usleep instead of rem = sleep(time) Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 21/21] Revert "tests: Disable qht-bench parallel test when using gprof" Alex Bennée
2019-01-14 15:31 ` Alex Bennée
2019-01-15 11:38 ` [Qemu-devel] [PULL 00/21] misc testing fixes for Travis and docker Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114150129.1013-13-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=fam@euphon.net \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).