From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: [Qemu-devel] [PULL 20/21] tests: use g_usleep instead of rem = sleep(time)
Date: Mon, 14 Jan 2019 15:01:28 +0000 [thread overview]
Message-ID: <20190114150129.1013-21-alex.bennee@linaro.org> (raw)
In-Reply-To: <20190114150129.1013-1-alex.bennee@linaro.org>
Relying on sleep to always return having slept isn't safe as a signal
may have occurred. If signals are constantly incoming the program will
never reach its termination condition. This is believed to be the
mechanism causing time outs for qht-test in Travis.
The glib g_usleep() deals with all of this for us so lets use it instead.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
diff --git a/tests/atomic64-bench.c b/tests/atomic64-bench.c
index 71692560ed..121a8c14f4 100644
--- a/tests/atomic64-bench.c
+++ b/tests/atomic64-bench.c
@@ -74,16 +74,14 @@ static void *thread_func(void *arg)
static void run_test(void)
{
- unsigned int remaining;
unsigned int i;
while (atomic_read(&n_ready_threads) != n_threads) {
cpu_relax();
}
+
atomic_set(&test_start, true);
- do {
- remaining = sleep(duration);
- } while (remaining);
+ g_usleep(duration * G_USEC_PER_SEC);
atomic_set(&test_stop, true);
for (i = 0; i < n_threads; i++) {
diff --git a/tests/atomic_add-bench.c b/tests/atomic_add-bench.c
index 2f6c72f63a..5666f6bbff 100644
--- a/tests/atomic_add-bench.c
+++ b/tests/atomic_add-bench.c
@@ -76,16 +76,14 @@ static void *thread_func(void *arg)
static void run_test(void)
{
- unsigned int remaining;
unsigned int i;
while (atomic_read(&n_ready_threads) != n_threads) {
cpu_relax();
}
+
atomic_set(&test_start, true);
- do {
- remaining = sleep(duration);
- } while (remaining);
+ g_usleep(duration * G_USEC_PER_SEC);
atomic_set(&test_stop, true);
for (i = 0; i < n_threads; i++) {
diff --git a/tests/qht-bench.c b/tests/qht-bench.c
index ab4e708180..e3b512f26f 100644
--- a/tests/qht-bench.c
+++ b/tests/qht-bench.c
@@ -398,16 +398,14 @@ static void pr_stats(void)
static void run_test(void)
{
- unsigned int remaining;
int i;
while (atomic_read(&n_ready_threads) != n_rw_threads + n_rz_threads) {
cpu_relax();
}
+
atomic_set(&test_start, true);
- do {
- remaining = sleep(duration);
- } while (remaining);
+ g_usleep(duration * G_USEC_PER_SEC);
atomic_set(&test_stop, true);
for (i = 0; i < n_rw_threads; i++) {
--
2.17.1
next prev parent reply other threads:[~2019-01-14 15:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 15:01 [Qemu-devel] [PULL 00/21] misc testing fixes for Travis and docker Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 01/21] docker: Use stable git tag for virglrenderer Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 02/21] tests: run ldconfig after installing extra software Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 03/21] tests: remove obsolete 'debian' dockerfile Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 04/21] tests: update Fedora dockerfile to use Fedora 29 Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 05/21] tests: update Fedora i386 cross image to " Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 06/21] tests: use in-place sed magic for enabling deb-src in travis image Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 07/21] travis: add whitespace between each major section & matrix entry Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 08/21] travis: define all the build matrix entries in one place Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 09/21] travis: standardize the syntax used for env variables Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 10/21] travis: don't clone git submodules upfront Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 11/21] travis: use homebrew addon for MacOSX Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 12/21] travis: stop redefining the script commands Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 13/21] travis: stop using container based envs Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 14/21] travis: run tests in verbose mode Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 15/21] travis: remove matrix settings that duplicate global settings Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 16/21] docker: Use a stable snapshot for Debian Sid Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 17/21] travis: bump to Xenial baseline Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 18/21] tests/docker: update our Travis image Alex Bennée
2019-01-14 15:01 ` [Qemu-devel] [PULL 19/21] tests/docker: remove SID_AGE test hack Alex Bennée
2019-01-14 15:01 ` Alex Bennée [this message]
2019-01-14 15:01 ` [Qemu-devel] [PULL 21/21] Revert "tests: Disable qht-bench parallel test when using gprof" Alex Bennée
2019-01-14 15:31 ` Alex Bennée
2019-01-15 11:38 ` [Qemu-devel] [PULL 00/21] misc testing fixes for Travis and docker Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114150129.1013-21-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).